public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [patch] x86_64: remove lock prefix from is_at_popf() tests
@ 2006-08-01 11:00 Chuck Ebbert
  2006-08-01 17:06 ` Andi Kleen
  0 siblings, 1 reply; 2+ messages in thread
From: Chuck Ebbert @ 2006-08-01 11:00 UTC (permalink / raw)
  To: Andi Kleen; +Cc: linux-kernel

The lock prefix will cause an exception when used with the
popf instruction, so no need to continue searching after it's
found.

Signed-off-by: Chuck Ebbert <76306.1226@compuserve.com>

--- 2.6.18-rc3-64.orig/arch/x86_64/kernel/ptrace.c
+++ 2.6.18-rc3-64/arch/x86_64/kernel/ptrace.c
@@ -138,7 +138,7 @@ static int is_at_popf(struct task_struct
 		case 0x26: case 0x2e:
 		case 0x36: case 0x3e:
 		case 0x64: case 0x65:
-		case 0xf0: case 0xf2: case 0xf3:
+		case 0xf2: case 0xf3:
 			continue;
 
 		case 0x40 ... 0x4f:
@@ -148,7 +148,7 @@ static int is_at_popf(struct task_struct
 			/* 64-bit mode: REX prefix */
 			continue;
 
-			/* CHECKME: f0, f2, f3 */
+			/* CHECKME: f2, f3 */
 
 		/*
 		 * pushf: NOTE! We should probably not let
-- 
Chuck

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [patch] x86_64: remove lock prefix from is_at_popf() tests
  2006-08-01 11:00 [patch] x86_64: remove lock prefix from is_at_popf() tests Chuck Ebbert
@ 2006-08-01 17:06 ` Andi Kleen
  0 siblings, 0 replies; 2+ messages in thread
From: Andi Kleen @ 2006-08-01 17:06 UTC (permalink / raw)
  To: Chuck Ebbert; +Cc: linux-kernel

On Tuesday 01 August 2006 13:00, Chuck Ebbert wrote:
> The lock prefix will cause an exception when used with the
> popf instruction, so no need to continue searching after it's
> found.

Applied thanks.
-Andi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-08-01 17:26 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-01 11:00 [patch] x86_64: remove lock prefix from is_at_popf() tests Chuck Ebbert
2006-08-01 17:06 ` Andi Kleen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox