From: Jens Axboe <axboe@suse.de>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] ifdef blktrace debugging fields
Date: Wed, 2 Aug 2006 07:18:45 +0200 [thread overview]
Message-ID: <20060802051844.GF20108@suse.de> (raw)
In-Reply-To: <20060801224938.GA14863@martell.zuzino.mipt.ru>
On Wed, Aug 02 2006, Alexey Dobriyan wrote:
> On Tue, Aug 01, 2006 at 10:12:57PM +0200, Jens Axboe wrote:
> > > +#ifdef CONFIG_BLK_DEV_IO_TRACE
> > > if (q->blk_trace)
> > > blk_trace_shutdown(q);
> > > -
> > > +#endif
> > > kmem_cache_free(requestq_cachep, q);
> > > }
> >
> > That can be made ifdef less, if you unconditionally call
> > blk_trace_shutdown() and just make that one do:
> >
> > if (q->blk_trace) {
> > ...
> > }
> >
> > since that'll then do the right always. Please make that change, then
> > I'm fine with the patch.
>
> OK here goes version 3.
>
> [PATCH] ifdef blktrace debugging fields
Looks good!
Acked-by: Jens Axboe <axboe@suse.de>
--
Jens Axboe
prev parent reply other threads:[~2006-08-02 5:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <200608010657.k716vBWF004420@shell0.pdx.osdl.net>
[not found] ` <20060801071658.GG31908@suse.de>
[not found] ` <20060801002904.53407219.akpm@osdl.org>
[not found] ` <20060801074436.GJ31908@suse.de>
2006-08-01 13:47 ` [PATCH] ifdef blktrace debugging fields Alexey Dobriyan
2006-08-01 20:12 ` Jens Axboe
2006-08-01 22:49 ` [PATCH v3] " Alexey Dobriyan
2006-08-02 5:18 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060802051844.GF20108@suse.de \
--to=axboe@suse.de \
--cc=adobriyan@gmail.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox