Re: [Xen-devel] Re: [PATCH 8 of 13] Add a bootparameter to reserve high linear address space for hypervisors

Rusty Russell
2006-08-02T05:21:03Z

On Wed, 2006-08-02 at 06:36 +0200, Andi Kleen wrote:
> Please just make a proper patch - either add a call to it to all setup_archs,
> or add a call to before setup_arch in init/main.c. While such ifdefs
> for specific architecture hacks are more popular lately it doesn't mean they are a good idea.

It's been around for two years, but if you fix x86_64 to use
early_param(), and I'll patch the other setup_archs to call
parse_early_param and remove the init/main.c call 8)

> I hope there aren't any existing architectures that use it in the middle
> of setup_arch or rely on it being after setup_arch.

setup_arch is responsible for grabbing the command line, so that has to
happen first. Even on x86, functions later in setup_arch rely on
cmdline parsing having happened. So for the moment setup_arch has to
call parse_early_param.

Maybe one day we can create a new "char *arch_get_cmdline()", implement
that everywhere, then call it and parse_early_param from core code. But
baby steps...

Rusty.