Re: [PATCH 8 of 13] Add a bootparameter to reserve high linear address space for hypervisors

Rusty Russell
2006-08-02T00:48:11Z

On Tue, 2006-08-01 at 23:47 +0200, Andi Kleen wrote:
> > + /*
> > + * reservedtop=size reserves a hole at the top of the kernel
> > + * address space which a hypervisor can load into later.
> > + * Needed for dynamically loaded hypervisors, so relocating
> > + * the fixmap can be done before paging initialization.
> > + * This hole must be a multiple of 4M.
> > + */
> > + else if (!memcmp(from, "reservedtop=", 12)) {
> > + unsigned long reserved = memparse(from+12, &from);
> > + reserved &= ~0x3fffff;
> > + set_fixaddr_top(-reserved);
> > + }
>
> You need to add a dummy __setup for it, otherwise it will end up in
> init's environments or be warned about.

Ewww, it's not the only one. This whole function should be replaced
with a whole heap of early_param()s and a call to parse_early_param().

I only implemented parse_early_param two years ago; maybe it is time for
i386 to use it...

I'll create a patch,
Rusty.