From: Rolf Eike Beer <eike-kernel@sf-tec.de>
To: Dave Jones <davej@redhat.com>
Cc: Andreas Schwab <schwab@suse.de>,
Alexey Dobriyan <adobriyan@gmail.com>,
Alan Cox <alan@lxorguk.ukuu.org.uk>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: single bit flip detector.
Date: Wed, 2 Aug 2006 08:20:26 +0200 [thread overview]
Message-ID: <200608020820.31931.eike-kernel@sf-tec.de> (raw)
In-Reply-To: <20060802001626.GA14689@redhat.com>
[-- Attachment #1: Type: text/plain, Size: 920 bytes --]
Dave Jones wrote:
> On Tue, Aug 01, 2006 at 07:51:09PM -0400, Dave Jones wrote:
> > I'm going for the record of 'most times a patch gets submitted in one
> > day'. And to think we were complaining that patches don't get enough
> > review ? :) If every change had this much polish, we'd be awesome.
>
> Sigh. Spaces before printk. Whatever next.
> I am now officially bored of seeing this patch.
> diff --git a/mm/slab.c b/mm/slab.c
> index 21ba060..39f1183 100644
> --- a/mm/slab.c
> +++ b/mm/slab.c
> @@ -1638,10 +1638,28 @@ static void poison_obj(struct kmem_cache
> static void dump_line(char *data, int offset, int limit)
> {
> int i;
> + unsigned char total = 0, bad_count = 0, errors;
> printk(KERN_ERR "%03x:", offset);
> - for (i = 0; i < limit; i++)
> + for (i = 0; i < limit; i++) {
You might want to add a newline before the actual code to make it more
readable :)
Eike
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2006-08-02 6:17 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 18:44 single bit flip detector Dave Jones
2006-08-01 20:15 ` Bill Davidsen
2006-08-01 22:14 ` Alan Cox
2006-08-01 22:30 ` Dave Jones
2006-08-01 22:36 ` Dave Jones
2006-08-01 23:00 ` Alexey Dobriyan
2006-08-01 23:16 ` Dave Jones
2006-08-01 23:27 ` Dave Jones
2006-08-01 23:28 ` Andreas Schwab
2006-08-01 23:51 ` Dave Jones
2006-08-02 0:16 ` Dave Jones
2006-08-02 6:20 ` Rolf Eike Beer [this message]
2006-08-02 7:08 ` Jan Engelhardt
2006-08-06 11:05 ` Geert Uytterhoeven
2006-08-02 15:24 ` Patrick McLean
2006-08-02 16:12 ` Randy.Dunlap
2006-08-04 21:19 ` Andrew Morton
2006-08-04 22:06 ` Dave Jones
2006-08-04 22:25 ` Andrew Morton
2006-08-04 22:28 ` Dave Jones
2006-08-02 7:08 ` Jan Engelhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608020820.31931.eike-kernel@sf-tec.de \
--to=eike-kernel@sf-tec.de \
--cc=adobriyan@gmail.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox