From: Jan Blunck <jblunck@suse.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] fix vmstat per cpu usage
Date: Wed, 2 Aug 2006 11:01:22 +0200 [thread overview]
Message-ID: <20060802090122.GN4995@hasse.suse.de> (raw)
In-Reply-To: <20060801140707.a55a0513.akpm@osdl.org>
On Tue, Aug 01, Andrew Morton wrote:
> >
> > static inline void __count_vm_event(enum vm_event_item item)
> > {
> > - __get_cpu_var(vm_event_states.event[item])++;
> > + __get_cpu_var(vm_event_states).event[item]++;
> > }
>
> How odd. Are there any negative consequences to the existing code?
In asm-s390/percpu.h we use
#define __get_cpu_var(var) __reloc_hide(var,S390_lowcore.percpu_offset)
and for modules on s390x __reloc_hide() is defined as
#define __reloc_hide(var,offset) \
(*({ unsigned long *__ptr; \
asm ( "larl %0,per_cpu__"#var"@GOTENT" \
: "=a" (__ptr) : "X" (per_cpu__##var) ); \
(typeof(&per_cpu__##var))((*__ptr) + (offset)); }))
which leads in this case to
larl %0, per_cpu__vm_event_states.event[item]@GOTENT
which is invalid asm.
next prev parent reply other threads:[~2006-08-02 9:01 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-01 17:36 [PATCH] fix vmstat per cpu usage Jan Blunck
2006-08-01 21:07 ` Andrew Morton
2006-08-01 22:44 ` Paul Mackerras
2006-08-02 9:01 ` Jan Blunck [this message]
2006-08-02 13:30 ` Jan Blunck
2006-08-02 14:43 ` Andrew Morton
2006-08-07 12:42 ` Jan Blunck
2006-08-02 16:54 ` Steve Fox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060802090122.GN4995@hasse.suse.de \
--to=jblunck@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox