Re: [PATCH 0/3] at91_serial: Introduction

Haavard Skinnemoen
2006-09-26T09:48:22Z

On 26 Sep 2006 11:28:11 +0200
Andrew Victor <andrew@sanpeople.com> wrote:

> hi Haavard,
>
> > Maybe we can agree on a platform_data format so
> > that we can remove the #ifdef altogether?
>
> The platform_data structure is currently defined in
> include/asm-arm/arch-at91rm9200/board.h as:
>
> struct at91_uart_data {
> short use_dma_tx; /* use transmit DMA? */
> short use_dma_rx; /* use receive DMA? */
> };
>
> I don't think the DMA-support is currently in mainline, but is in the
> pending patches on http://maxim.org.za/AT91RM9200/2.6/

Are you going to submit it for 2.6.19? I want to try to slam a big
rename patch in without messing up too many not-yet-submitted patches...

> I guess we can just add another field:
> short no_remap; /* base address is already
> mapped */ (or something similar)

Or maybe even better:
void __iomem *regs; /* fixed mapping of base address */

to indicate the actual mapping (if it's NULL, it hasn't been mapped yet)

Haavard