From: Muli Ben-Yehuda <muli@il.ibm.com>
To: Rolf Eike Beer <eike-kernel@sf-tec.de>
Cc: Andrew Morton <akpm@osdl.org>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Use valid_dma_direction() in include/asm-i386/dma-mapping.h
Date: Wed, 2 Aug 2006 21:56:29 +0300 [thread overview]
Message-ID: <20060802185629.GC4982@rhun.ibm.com> (raw)
In-Reply-To: <200608021722.35797.eike-kernel@sf-tec.de>
On Wed, Aug 02, 2006 at 05:22:35PM +0200, Rolf Eike Beer wrote:
> Now that the generic DMA code has a function to decide if a given DMA
> mapping is valid use it. This will catch cases where direction is not any
> of the defined enum values but some random number outside the valid range.
> The current implementation will only catch the defined but invalid case
> DMA_NONE.
>
> Signed-off-by: Rolf Eike Beer
Acked-by: Muli Ben-Yehuda <muli@il.ibm.com>
... but see my comments to your other patch this one depends on.
Cheers,
Muli
prev parent reply other threads:[~2006-08-02 18:56 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-28 7:28 [PATCH] Use BUG_ON(foo) instead of "if (foo) BUG()" in include/asm-i386/dma-mapping.h Rolf Eike Beer
2006-07-28 7:47 ` Andrew Morton
2006-08-05 11:37 ` Pavel Machek
2006-08-07 1:20 ` Adrian Bunk
2006-07-28 17:44 ` Muli Ben-Yehuda
2006-08-02 15:20 ` [PATCH] Move valid_dma_direction() from x86_64 to generic code Rolf Eike Beer
2006-08-02 18:55 ` Muli Ben-Yehuda
2006-08-03 6:25 ` Rolf Eike Beer
2006-08-03 7:23 ` Muli Ben-Yehuda
2006-08-03 21:10 ` IOMMU (Calgary) patches Duran, Leo
2006-08-03 21:25 ` Jon Mason
2006-08-03 21:35 ` Duran, Leo
2006-08-03 22:46 ` [discuss] " Andi Kleen
2006-08-02 15:22 ` [PATCH] Use valid_dma_direction() in include/asm-i386/dma-mapping.h Rolf Eike Beer
2006-08-02 18:56 ` Muli Ben-Yehuda [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060802185629.GC4982@rhun.ibm.com \
--to=muli@il.ibm.com \
--cc=akpm@osdl.org \
--cc=eike-kernel@sf-tec.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox