From: Pavel Machek <pavel@suse.cz>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Dave Hansen <haveblue@us.ibm.com>, Andrew Morton <akpm@osdl.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/3] swsusp: Fix mark_free_pages
Date: Wed, 2 Aug 2006 22:30:05 +0200 [thread overview]
Message-ID: <20060802203005.GF8124@elf.ucw.cz> (raw)
In-Reply-To: <200608022212.48293.rjw@sisk.pl>
Hi!
Looks good to me (ACK).
> if (page) {
> - long *src, *dst;
> - int n;
> + void *ptr = page_address(page);;
You probably want to remove one of ";"s.
Pavel
--
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
next prev parent reply other threads:[~2006-08-02 20:30 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-02 16:42 [PATCH 0/3] swsusp cleanups Rafael J. Wysocki
2006-08-02 16:48 ` [PATCH 1/3] swsusp: Fix mark_free_pages Rafael J. Wysocki
2006-08-02 19:51 ` Dave Hansen
2006-08-02 20:12 ` Rafael J. Wysocki
2006-08-02 20:30 ` Pavel Machek [this message]
2006-08-02 20:48 ` Rafael J. Wysocki
2006-08-02 16:53 ` [PATCH 2/3] swsusp: Reorder memory-allocating functions Rafael J. Wysocki
2006-08-02 20:19 ` Pavel Machek
2006-08-02 16:57 ` [PATCH 3/3] swsusp: Fix alloc_pagedir Rafael J. Wysocki
2006-08-02 20:22 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060802203005.GF8124@elf.ucw.cz \
--to=pavel@suse.cz \
--cc=akpm@osdl.org \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox