public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Willy Tarreau <w@1wt.eu>
To: mtosatti@redhat.com
Cc: linux-kernel@vger.kernel.org, Grant Coady <gcoady.lk@gmail.com>
Subject: [PATCH] 2.4.33-rc3 needs to export memchr() for smbfs
Date: Wed, 2 Aug 2006 23:46:08 +0200	[thread overview]
Message-ID: <20060802214608.GA1987@1wt.eu> (raw)

Hi Marcelo,

just finished building 2.4.33-rc3 on my dual-CPU Sun U60 (works
fine BTW). I noticed that smbfs built as a module needs memchr()
since a recent fix, so this one now needs to be exported, which
this patch does.  Sources show that the lp driver would need it
too is console on LP is enabled and LP is set as a module (which
seems stupid to me anyway). I've pushed it into -upstream if you
prefer to pull from it.

Overall, 2.4.33-rc3 seems to be OK to me. I don't think that
an additionnal -rc4 would be needed just for this export (Grant
CCed in case he's wishing to do a few more builds, you know
him...  :-) ).

Regards,
Willy


>From e3523609bec99d5c607fc00b4f68386d3390fb82 Mon Sep 17 00:00:00 2001
From: Willy Tarreau <w@1wt.eu>
Date: Wed, 2 Aug 2006 23:30:22 +0200
Subject: [PATCH] export memchr() which is used by smbfs and lp driver.

Recently, an smbfs fix added a dependency on memchr() which is
not exported if smbfs is built as a module.

Signed-Off-By: Willy Tarreau <w@1wt.eu>
---
 kernel/ksyms.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/ksyms.c b/kernel/ksyms.c
index d1e66c7..73ad3e9 100644
--- a/kernel/ksyms.c
+++ b/kernel/ksyms.c
@@ -579,6 +579,7 @@ EXPORT_SYMBOL(get_write_access);
 EXPORT_SYMBOL(strnicmp);
 EXPORT_SYMBOL(strspn);
 EXPORT_SYMBOL(strsep);
+EXPORT_SYMBOL(memchr);
 
 #ifdef CONFIG_CRC32
 EXPORT_SYMBOL(crc32_le);
-- 
1.4.1


             reply	other threads:[~2006-08-02 21:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-02 21:46 Willy Tarreau [this message]
2006-08-03  1:21 ` [PATCH] 2.4.33-rc3 needs to export memchr() for smbfs Grant Coady
2006-08-03  2:40   ` Willy Tarreau
2006-08-03  3:26     ` Grant Coady
2006-08-03  4:24       ` Willy Tarreau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060802214608.GA1987@1wt.eu \
    --to=w@1wt.eu \
    --cc=gcoady.lk@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtosatti@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox