From: Andi Kleen <ak@suse.de>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: Linus Torvalds <torvalds@osdl.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Albert Cahalan <acahalan@gmail.com>
Subject: Re: [patch] x86: rename is_at_popf(), add iret to tests and fix insn length
Date: Thu, 3 Aug 2006 00:12:07 +0200 [thread overview]
Message-ID: <200608030012.07247.ak@suse.de> (raw)
In-Reply-To: <200608020937_MC3-1-C6D7-3958@compuserve.com>
On Wednesday 02 August 2006 15:35, Chuck Ebbert wrote:
> In-Reply-To: <200608021454.33685.ak@suse.de>
>
> On Wed, 2 Aug 2006 14:54:33 +0200. Andi Kleen wrote:
>
> > > is_at_popf() needs to test for the iret instruction as well as
> > > popf. So add that test and rename it to is_setting_trap_flag().
> >
> > Do you have a single real example where anybody is actually using IRET
> > in user space?
>
> No, but Albert Cahalan complained so I figured it should be fixed.
I suppose he just collected all the obscure FIXMEs in the code he could find.
Ok I merged it, but only because it is so little code.
-Andi
next prev parent reply other threads:[~2006-08-02 22:13 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-02 13:35 [patch] x86: rename is_at_popf(), add iret to tests and fix insn length Chuck Ebbert
2006-08-02 22:12 ` Andi Kleen [this message]
[not found] <6FokL-6q5-7@gated-at.bofh.it>
[not found] ` <6Fouu-6Ch-17@gated-at.bofh.it>
2006-08-02 21:29 ` Bodo Eggert
-- strict thread matches above, loose matches on Subject: below --
2006-08-02 12:37 Chuck Ebbert
2006-08-02 12:54 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608030012.07247.ak@suse.de \
--to=ak@suse.de \
--cc=76306.1226@compuserve.com \
--cc=acahalan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox