Re: [PATCH 02/28] r/o bind mount prepwork: move open_namei()'s vfs_create()

Christoph Hellwig
2006-08-03T14:33:19Z

On Tue, Aug 01, 2006 at 04:52:41PM -0700, Dave Hansen wrote:
>
> The code around vfs_create() in open_namei() is getting a
> bit too complex. Right now, there is at least the reference
> count on the dentry, and the i_mutex to worry about. Soon,
> we'll also have mnt_writecount.
>
> So, break the vfs_create() call out of open_namei(), and
> into a helper function. This duplicates the call to
> may_open(), but that isn't such a bad thing since the
> arguments (acc_mode and flag) were being heavily massaged
> anyway.
>
> Later in the series, we'll add the mnt_writecount handling
> around this new function call.
>

Ok. Again please send to Andrew ASAP.