From: Keith Mannthey <kmannth@us.ibm.com>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org, discuss@x86-64.org,
Keith Mannthey <kmannth@us.ibm.com>,
ak@suse.de, lhms-devel@lists.sourceforge.net,
kamezawa.hiroyu@jp.fujitsu.com
Subject: [PATCH 10/10] hot-add-mem x86_64: valid add range check
Date: Fri, 4 Aug 2006 07:14:45 -0600 [thread overview]
Message-ID: <20060804131445.21401.73592.sendpatchset@localhost.localdomain> (raw)
In-Reply-To: <20060804131351.21401.4877.sendpatchset@localhost.localdomain>
From: Keith Mannthey <kmannth@us.ibm.com>
Introduce and implement valid_add_memory_range to MEMORY_HOTPLUG. The
RESERVE path needs to be careful about check to make sure it only onlines
correct memory. The SPASRMEM path is using resource code to do this so
it gets a no-op check. This frame work makes it was to add specific checks
for valid add memory ranges as the need arises.
Signed-off-by: Keith Mannthey<kmannth@us.ibm.com>
---
arch/x86_64/mm/srat.c | 6 ++++++
include/linux/memory_hotplug.h | 2 +-
mm/memory_hotplug.c | 8 ++++++++
3 files changed, 15 insertions(+), 1 deletion(-)
diff -urN orig/arch/x86_64/mm/srat.c current/arch/x86_64/mm/srat.c
--- orig/arch/x86_64/mm/srat.c 2006-08-04 06:56:24.000000000 -0400
+++ current/arch/x86_64/mm/srat.c 2006-08-04 03:39:29.000000000 -0400
@@ -203,6 +203,12 @@
{
return hotadd_percent > 0;
}
+
+inline int valid_add_memory_range(int nid, u64 start, u64 size) {
+ if (nodes_add[nid].start <= start && nodes_add[nid].end >= (start+size))
+ return 1;
+ return 0;
+}
#else
int update_end_of_memory(unsigned long end) {return 0;}
static int hotadd_enough_memory(struct bootnode *nd) {return 1;}
diff -urN orig/include/linux/memory_hotplug.h current/include/linux/memory_hotplug.h
--- orig/include/linux/memory_hotplug.h 2006-08-04 06:56:24.000000000 -0400
+++ current/include/linux/memory_hotplug.h 2006-08-04 02:08:45.000000000 -0400
@@ -159,7 +159,7 @@
dump_stack();
return -ENOSYS;
}
-
+extern int valid_add_memory_range(int nid, u64 start, u64 size);
#endif /* ! CONFIG_MEMORY_HOTPLUG */
static inline int __remove_pages(struct zone *zone, unsigned long start_pfn,
unsigned long nr_pages)
diff -urN orig/mm/memory_hotplug.c current/mm/memory_hotplug.c
--- orig/mm/memory_hotplug.c 2006-08-04 06:59:05.000000000 -0400
+++ current/mm/memory_hotplug.c 2006-08-04 03:08:23.000000000 -0400
@@ -220,6 +220,11 @@
vm_total_pages = nr_free_pagecache_pages();
return 0;
}
+
+inline int valid_add_memory_range(int nid, u64 start, u64 size) {
+ return 1;
+}
+
#endif /* CONFIG_MEMORY_HOTPLUG_SPARSE */
static pg_data_t *hotadd_new_pgdat(int nid, u64 start)
@@ -257,6 +262,9 @@
int new_pgdat = 0;
struct resource *res;
int ret;
+
+ if (!valid_add_memory_range(nid,start,size))
+ return -EINVAL;
res = register_memory_resource(start, size);
if (!res)
next prev parent reply other threads:[~2006-08-04 13:15 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-04 13:13 [PATCH 1/10] hot-add-mem x86_64: acpi motherboard fix Keith Mannthey
2006-08-04 13:13 ` [PATCH 2/10] hot-add-mem x86_64: fixup externs Keith Mannthey
2006-08-04 13:14 ` [PATCH 3/10] hot-add-mem x86_64: Kconfig changes Keith Mannthey
2006-08-04 13:14 ` [PATCH 4/10] hot-add-mem x86_64: Enable SPARSEMEM in srat.c Keith Mannthey
2006-08-04 15:17 ` [Lhms-devel] " Mika Penttilä
2006-08-04 19:36 ` keith mannthey
2006-08-04 17:42 ` Dave Hansen
2006-08-04 13:14 ` [PATCH 5/10] hot-add-mem x86_64: memory_add_physaddr_to_nid enable Keith Mannthey
2006-08-04 13:14 ` [PATCH 7/10] hot-add-mem x86_64: x86_64 kernel mapping fix Keith Mannthey
2006-08-04 13:14 ` [PATCH 8/10] hot-add-mem x86_64: use CONFIG_MEMORY_HOTPLUG_SPARSE Keith Mannthey
2006-08-04 13:14 ` [PATCH 9/10] hot-add-mem x86_64: use CONFIG_MEMORY_HOTPLUG_RESERVE Keith Mannthey
2006-08-07 17:41 ` keith mannthey
2006-08-04 13:14 ` Keith Mannthey [this message]
2006-08-05 5:39 ` [PATCH 1/10] hot-add-mem x86_64: acpi motherboard fix KAMEZAWA Hiroyuki
2006-08-05 5:51 ` KAMEZAWA Hiroyuki
2006-08-07 18:39 ` keith mannthey
2006-08-08 0:31 ` [Lhms-devel] " KAMEZAWA Hiroyuki
2006-08-08 0:56 ` keith mannthey
2006-08-08 2:08 ` KAMEZAWA Hiroyuki
2006-08-08 2:15 ` keith mannthey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060804131445.21401.73592.sendpatchset@localhost.localdomain \
--to=kmannth@us.ibm.com \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=discuss@x86-64.org \
--cc=kamezawa.hiroyu@jp.fujitsu.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox