public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Jiri Slaby <jirislaby@gmail.com>
Cc: linux-kernel@vger.kernel.org, support@moxa.com.tw
Subject: Re: [RFC 1/2] Char: mxser, upgrade to 1.9.1
Date: Fri, 4 Aug 2006 17:06:08 -0700	[thread overview]
Message-ID: <20060804170608.fdafbc0d.akpm@osdl.org> (raw)
In-Reply-To: <44D3DDD7.2010608@gmail.com>

On Sat, 05 Aug 2006 01:52:32 +0159
Jiri Slaby <jirislaby@gmail.com> wrote:

> Andrew Morton wrote:
> > On Sat, 29 Jul 2006 15:29:43 -0400
> > Jiri Slaby <jirislaby@gmail.com> wrote:
> > 
> >> mxser, upgrade to 1.9.1
> >>
> >> Change driver according to original 1.9.1 moxa driver.
> > 
> > Where did these changes come from?  The Moxa website, perhaps?
> > 
> > Do we know what they do?  Have you been able to test it?
> 
> Ok. Bernard did not test it:
> <cite>
> In fact, due to distro version differences between mine and the one
> installed on my friends linuxbox (I was running Mandriva 2006 with 2.6
> kernel and he had a Knoppix system with 2.4 kernel), I did not had the
> opportunity to check if the new version sent by Moxa support worked
> before he disappeared.
> But I dont see any reason it would not. Moxa guys have all the hardware
> in their development departement to check their product drivers.
> 
> I just verified that 1.9.1 driver source could be compiled under kernel
> 2.6. and so did it.
> </cite>
> 
> So, what do you expect me to do, Andrew? Add just pci_ids + its config with no 
> int->ulong conversion + writing ~UART_IER_THRI to the port?

It's hard.

Perhaps we could merge it and stick a printk in there saying "if you have
the hardware for this driver, please send an email to ...".

Then when we get a few people we ask them "do you want to become an mxser
tester".

Then we add a comment to the driver (or ./TESTERS) recording the names of
the people who have volunteered to test this driver.

So next time this sort of thing happens, we know what to do.

Would such a system work?  Maybe.  Partially.  If it does, it would be
modestly useful.


      reply	other threads:[~2006-08-05  0:06 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-07-29 19:29 [RFC 1/2] Char: mxser, upgrade to 1.9.1 Jiri Slaby
2006-07-30 19:31 ` Andrew Morton
2006-07-30 20:13   ` Jiri Slaby
2006-08-04 23:53   ` Jiri Slaby
2006-08-05  0:06     ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060804170608.fdafbc0d.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=jirislaby@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=support@moxa.com.tw \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox