From: Dave Jones <davej@redhat.com>
To: Andrew Morton <akpm@osdl.org>
Cc: torvalds@osdl.org, michal.k.k.piotrowski@gmail.com,
linux-kernel@vger.kernel.org
Subject: Re: 2.6.18-rc3-g3b445eea BUG: warning at /usr/src/linux-git/kernel/cpu.c:51/unlock_cpu_hotplug()
Date: Sat, 5 Aug 2006 15:47:30 -0400 [thread overview]
Message-ID: <20060805194730.GG13393@redhat.com> (raw)
In-Reply-To: <20060805004600.2e63fcd9.akpm@osdl.org>
On Sat, Aug 05, 2006 at 12:46:00AM -0700, Andrew Morton wrote:
> @@ -320,10 +320,10 @@ void fastcall flush_workqueue(struct wor
> } else {
> int cpu;
>
> - lock_cpu_hotplug();
> + mutex_lock(&workqueue_mutex);
> for_each_online_cpu(cpu)
> flush_cpu_workqueue(per_cpu_ptr(wq->cpu_wq, cpu));
> - unlock_cpu_hotplug();
> + mutex_unlock(&workqueue_mutex);
> }
> }
Is this enough though? I mean, what stops the hotplug cpu code
from modifying cpu_online_map underneath us here, making for_each_online_cpu
do the wrong thing ?
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2006-08-05 19:47 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-04 19:04 2.6.18-rc3-g3b445eea BUG: warning at /usr/src/linux-git/kernel/cpu.c:51/unlock_cpu_hotplug() Michal Piotrowski
2006-08-04 19:24 ` Linus Torvalds
2006-08-04 22:24 ` Dave Jones
2006-08-05 0:31 ` Dave Jones
2006-08-05 2:10 ` Dave Jones
2006-08-05 2:23 ` Dave Jones
2006-08-05 2:49 ` Dave Jones
2006-08-05 6:47 ` Dave Jones
2006-08-05 7:46 ` Andrew Morton
2006-08-05 19:47 ` Dave Jones [this message]
2006-08-05 20:02 ` Andrew Morton
2006-08-06 1:12 ` Andrew Morton
2006-08-05 10:54 ` Michal Piotrowski
2006-08-05 11:11 ` Michal Piotrowski
2006-08-05 11:26 ` Michal Piotrowski
2006-08-05 18:47 ` Dave Jones
2006-08-05 21:15 ` Michal Piotrowski
2006-08-06 16:59 ` Michal Piotrowski
2006-08-06 18:05 ` Dave Jones
2006-08-06 19:32 ` Andrew Morton
2006-08-07 1:26 ` Andi Kleen
2006-08-07 8:18 ` Jan Beulich
2006-08-15 12:23 ` Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2006-08-05 22:14 art
2006-08-06 1:23 ` Dave Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060805194730.GG13393@redhat.com \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=michal.k.k.piotrowski@gmail.com \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox