From: Andi Kleen <ak@muc.de>
To: Rusty Russell <rusty@rustcorp.com.au>
Cc: lkml - Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Turn rdmsr, rdtsc into inline functions, clarify names
Date: 6 Aug 2006 04:38:24 +0200
Date: Sun, 6 Aug 2006 04:38:24 +0200 [thread overview]
Message-ID: <20060806023824.GA41762@muc.de> (raw)
In-Reply-To: <1154771262.28257.38.camel@localhost.localdomain>
On Sat, Aug 05, 2006 at 07:47:41PM +1000, Rusty Russell wrote:
> [Andi, sorry, x86_64 part untested, so sending straight to you]
>
> rdmsr and rdtsc are macros, altering their arguments directly. An
> inline function would offer decent typechecking, but needs to take
> pointer args. The comment notes that gcc produces better code with
I think I prefer the macro variant actually. Sorry. It just looks
better without the &s.
We don't care very much about the code quality here because
rdmsr/wrmsr are always very slow in microcode anyways and tend
to synchronize the CPUs.
If you feel a need to clean up I would suggest you convert more
users over to the ll variants which take a single 64bit value
instead of two 32bit ones.
-Andi
next parent reply other threads:[~2006-08-06 2:38 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1154771262.28257.38.camel@localhost.localdomain>
2006-08-06 2:38 ` Andi Kleen [this message]
2006-08-06 2:56 ` [PATCH] Turn rdmsr, rdtsc into inline functions, clarify names Rusty Russell
2006-08-06 2:58 ` H. Peter Anvin
2006-08-06 3:09 ` Rusty Russell
2006-08-06 3:11 ` H. Peter Anvin
2006-08-06 3:49 ` Rusty Russell
2006-08-06 3:16 ` Andi Kleen
2006-08-06 3:52 ` Rusty Russell
2006-08-06 14:58 ` Andi Kleen
2006-08-07 2:43 ` Dmitry Torokhov
2006-08-07 8:48 ` Andi Kleen
2006-08-07 11:09 ` Vojtech Pavlik
2006-08-07 12:28 ` Andi Kleen
2006-08-07 12:48 ` Vojtech Pavlik
2006-08-07 12:56 ` Andi Kleen
2006-08-07 13:18 ` Vojtech Pavlik
2006-08-07 13:32 ` Dmitry Torokhov
2006-08-07 15:01 ` Andi Kleen
2006-08-07 15:19 ` Andreas Mohr
2006-08-07 15:57 ` Andi Kleen
2006-08-07 16:04 ` Vojtech Pavlik
2006-08-07 16:12 ` Andi Kleen
2006-08-07 19:22 ` Vojtech Pavlik
2006-08-14 20:13 ` Pavel Machek
2006-08-07 11:07 ` Vojtech Pavlik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060806023824.GA41762@muc.de \
--to=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustcorp.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox