From: Greg KH <greg@kroah.com>
To: Matthew Wilcox <matthew@wil.cx>
Cc: linux-kernel@vger.kernel.org
Subject: Re: dev_printk() is now GPL-only
Date: Sun, 6 Aug 2006 20:09:58 -0700 [thread overview]
Message-ID: <20060807030958.GA638@kroah.com> (raw)
In-Reply-To: <20060807025723.GK4379@parisc-linux.org>
On Sun, Aug 06, 2006 at 08:57:23PM -0600, Matthew Wilcox wrote:
>
> Does dev_driver_string() really need to be GPL-only? Up to this point,
> proprietary modules have been entitled to call dev_printk(), but now:
>
> #define dev_printk(level, dev, format, arg...) \
> printk(level "%s %s: " format , dev_driver_string(dev) , (dev)->bus_id , ## arg)
>
> with
>
> EXPORT_SYMBOL_GPL(dev_driver_string);
>
> means that they're not allowed to.
Oops, good point, I never noticed, as I don't have an closed source
drivers here to test with :)
Care to send me a patch to fix it up?
thanks,
greg k-h
next prev parent reply other threads:[~2006-08-07 3:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-07 2:57 dev_printk() is now GPL-only Matthew Wilcox
2006-08-07 3:09 ` Greg KH [this message]
2006-09-24 5:35 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060807030958.GA638@kroah.com \
--to=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
--cc=matthew@wil.cx \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox