Re: 2.6.18-rc3-mm2 early_param mem= fix

[Andi Kleen <ak@suse.de>]

On Monday 07 August 2006 05:08, Rusty Russell wrote:
> On Mon, 2006-08-07 at 04:55 +0200, Andi Kleen wrote:
> > On Monday 07 August 2006 04:54, Rusty Russell wrote:
> > > On Sun, 2006-08-06 at 18:22 +0100, Hugh Dickins wrote:
> > > > but I wonder how many other early_param
> > > > "option=" args are wrong (e.g. "memmap=" in the same file): x86_64
> > > > shows many such, i386 shows only one, I've not followed it up further.
> > > 
> > > Thanks Hugh.
> > > 
> > > Andrew, here's that i386 fix:
> > 
> > I had already fixed that one and the x86-64 ones.
> > 
> > But it still doesn't boot on x86-64 - gets into an endless loop
> > at boot. I'm suspecting the code can't deal with duplicated
> > prefixes.
> 
> Works fine here:

32bit works for me too, but x86-64 does. Strangely it seems to somehow
reenter head64 copy_boot_data. Perhaps stack gets smashed somehow?

It goes into an endless loop of:
Bootdata ok (command line is ip=dhcp nfsroot=10.23.204.1:/home/nfsroot/gaston root=/dev/nfs debug vga=0x0f07 rw pci=noacpi earlyprintk=serial,ttyS0,115200 console=ttyS0,115200 earlyprintk=serial,ttyS0,115200 console=tty0 BOOT_IMAGE=bzImage )
Bootdata ok (command line is ip=dhcp nfsroot=10.23.204.1:/home/nfsroot/gaston root=/dev/nfs debug vga=0x0f07 rw pci=noacpi earlyprintk=serial,ttyS0,115200 console=ttyS0,115200 earlyprintk=serial,ttyS0,115200 console=tty0 BOOT_IMAGE=bzImage )
Bootdata ok (command line is ip=dhcp nfsroot=10.23.204.1:/home/nfsroot/gaston root=/dev/nfs debug vga=0x0f07 rw pci=noacpi earlyprintk=serial,ttyS0,115200 console=ttyS0,115200 earlyprintk=serial,ttyS0,115200 console=tty0 BOOT_IMAGE=bzImage )
etc.

That is with all =s removed in early_params (i got that wrong in a lot of cases
-- the only option I tested was apic which didn't have it)

-Andi

>