Re: [PATCH] fix vmstat per cpu usage

Andrew Morton
2006-08-01T21:07:14Z

On Tue, 1 Aug 2006 19:36:21 +0200
Jan Blunck <jblunck@suse.de> wrote:

> The per cpu variables are used incorrectly in vmstat.h.
>
> Signed-off-by: Jan Blunck <jblunck@suse.de>
> ---
> include/linux/vmstat.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> Index: linux-v2.6.18-rc3/include/linux/vmstat.h
> ===================================================================
> --- linux-v2.6.18-rc3.orig/include/linux/vmstat.h
> +++ linux-v2.6.18-rc3/include/linux/vmstat.h
> @@ -41,23 +41,23 @@ DECLARE_PER_CPU(struct vm_event_state, v
>
> static inline void __count_vm_event(enum vm_event_item item)
> {
> - __get_cpu_var(vm_event_states.event[item])++;
> + __get_cpu_var(vm_event_states).event[item]++;
> }

How odd. Are there any negative consequences to the existing code?