public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Jens Axboe <axboe@suse.de>
To: Matthias Dahl <mlkernel@mortal-soul.de>
Cc: linux-kernel@vger.kernel.org
Subject: Re: sluggish system responsiveness under higher IO load
Date: Mon, 7 Aug 2006 15:48:42 +0200	[thread overview]
Message-ID: <20060807134841.GC10444@suse.de> (raw)
In-Reply-To: <200608061554.42992.mlkernel@mortal-soul.de>

On Sun, Aug 06 2006, Matthias Dahl wrote:
> > I'd suggest that you generate a kernel profile while the sluggishness is
> > happening.
> 
> Done...
> 
> profile 1: (emerge of three huge packages which caused quite some IO)

Can you see if this makes any difference whatsoever?

diff --git a/block/ll_rw_blk.c b/block/ll_rw_blk.c
index 61d6b3c..ed6a30e 100644
--- a/block/ll_rw_blk.c
+++ b/block/ll_rw_blk.c
@@ -3422,6 +3422,7 @@ #endif /* CONFIG_HOTPLUG_CPU */
 
 void blk_complete_request(struct request *req)
 {
+#if 0
 	struct list_head *cpu_list;
 	unsigned long flags;
 
@@ -3434,6 +3435,14 @@ void blk_complete_request(struct request
 	raise_softirq_irqoff(BLOCK_SOFTIRQ);
 
 	local_irq_restore(flags);
+#else
+	unsigned long flags;
+	request_queue_t *q = req->q;
+
+	local_irq_save(flags);
+	q->softirq_done_fn(req);
+	local_irq_restore(flags);
+#endif
 }
 
 EXPORT_SYMBOL(blk_complete_request);

-- 
Jens Axboe


  parent reply	other threads:[~2006-08-07 13:47 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-06 10:00 sluggish system responsiveness under higher IO load Matthias Dahl
2006-08-06 10:15 ` Andrew Morton
2006-08-06 13:54   ` Matthias Dahl
2006-08-06 19:37     ` Andrew Morton
2006-08-08 15:47       ` Matthias Dahl
2006-08-07 13:48     ` Jens Axboe [this message]
2006-08-08 15:56       ` Matthias Dahl
2006-08-08 17:44       ` Matthias Dahl
2006-08-08 19:02         ` Jens Axboe
2006-08-10 12:28           ` Jens Axboe
2006-08-11 11:40             ` Matthias Dahl
2006-08-13 16:15             ` Matthias Dahl
2006-10-06 15:58               ` Paolo Ornati
2006-10-08 14:28                 ` Christian
2006-10-08 17:05                   ` Jens Axboe
2006-10-08 23:50                     ` Jesper Juhl
2006-10-09  5:58                       ` Jens Axboe
2006-10-14 14:39                 ` Matthias Dahl
2006-10-14 14:57                   ` Paolo Ornati
2006-10-14 18:20                   ` Mike Galbraith
2006-09-03 11:15             ` Matthias Dahl
2006-09-15 18:17               ` Jens Axboe
2006-09-24 14:32                 ` Matthias Dahl
2006-09-24 20:27                   ` Mike Galbraith

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060807134841.GC10444@suse.de \
    --to=axboe@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mlkernel@mortal-soul.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox