Re: [PATCH 05/12] hdaps: Remember keyboard and mouse activity

[Pavel Machek <pavel@suse.cz>]

Hi!

> When the current hdaps driver is queried for recent keyboard/mouse activity
> (which is provided by the hardware for use in disk parking daemons), it
> simply returns the last readout. However, every hardware query resets the
> activity flag in the hardware, and this is triggered by (almost) any
> hdaps sysfs attribute read, so the flag could be reset before it is 
> observed and is thus nearly useless.
> 
> This patch makes the activities flags persist for 0.1sec, by remembering
> when was the last time we saw them set. This gives apps like the hdaps
> daemon enough time to poll the flag.

Should we perhaps remember time of last activity instead of 0/1? Aha,
that is how it is implemented, but would not time value be better
userland interface, too?

Ok... changing userland interface should be separate patch, anyway.
And should not hdapsd get it from input interface?

Signed-off-by: Pavel Machek <pavel@suse.cz>


-- 
Thanks for all the (sleeping) penguins.