Re: [patch] Re: 2.6.18-rc3-mm2 - OOM storm

Laurent Riffard
2006-08-12T21:25:10Z

Le 12.08.2006 17:07, Mike Galbraith a écrit :
> On Thu, 2006-08-10 at 02:19 -0700, Andrew Morton wrote:
>
>> It would be interesting to try disabling CONFIG_ADAPTIVE_READAHEAD -
>> perhaps that got broken.
>
> A typo was pinning pagecache. Fixes leak encountered with rpm -qaV.

Problem fixed here too. Thanks

> Signed-off-by: Mike Galbraith <efault@gmx.de>
>
> --- linux-2.6.18-rc3-mm2/mm/filemap.c.org 2006-08-12 14:04:14.000000000 +0000
> +++ linux-2.6.18-rc3-mm2/mm/filemap.c 2006-08-12 14:07:53.000000000 +0000
> @@ -1498,7 +1498,7 @@ retry_find:
> page_cache_readahead_adaptive(mapping, ra,
> file, NULL, NULL,
> pgoff, pgoff, pgoff + 1);
> - page = find_lock_page(mapping, pgoff);
> + page = find_get_page(mapping, pgoff);
> } else if (PageReadahead(page)) {
> page_cache_readahead_adaptive(mapping, ra,
> file, NULL, page,
>
>

--
laurent