Re: 2.6.18-rc3-mm2

Balbir Singh
2006-08-07T14:05:18Z

Michal Piotrowski wrote:
> Hi,
>
> On 07/08/06, Balbir Singh <balbir@in.ibm.com> wrote:
>> Michal Piotrowski wrote:
>> > Hi,
>> >
>> > On 06/08/06, Andrew Morton <akpm@osdl.org> wrote:
>> >>
>> >>
>> ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.18-rc3/2.6.18-rc3-mm2/
>>
>> >>
>> >>
>> >
>> > I get this error during the build.
>> >
>> > kernel/built-in.o: In function `bacct_add_tsk':
>> > /usr/src/linux-mm/kernel/tsacct.c:39: undefined reference to `__divdi3'
>> > make[1]: *** [.tmp_vmlinux1] Error 1
>> > make: *** [_all] Error 2
>> >
>> > I'll try with CONFIG_TASKSTATS disabled.
>> >
>> > Regards,
>> > Michal
>> >
>>
>> Sounds likes we are trying to do a 64 bit division since timespec_to_ns()
>> returns a 64 bit value.
>>
>> Here's a compile tested patch to fix the problem
>>
>
> It doesn't apply
> cat patches/tsacct1.patch | patch -p1 --dry-run
> patching file kernel/tsacct.c
> Hunk #1 FAILED at 36.
> 1 out of 1 hunk FAILED -- saving rejects to file kernel/tsacct.c.rej
>
> Andrew's csa-basic-accounting-over-taskstats-fix.patch fix compilation
> problem.
>

Yeah, thats it! I did not see the fix in mm-commits.

Thanks for pointing to the fix.

--

Balbir Singh,
Linux Technology Center,
IBM Software Labs