From: Sam Ravnborg <sam@ravnborg.org>
To: Greg KH <greg@kroah.com>
Cc: Andrew Morton <akpm@osdl.org>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PATCH] kbuild fixes for 2.6.18
Date: Mon, 7 Aug 2006 23:02:09 +0200 [thread overview]
Message-ID: <20060807210209.GA14327@mars.ravnborg.org> (raw)
In-Reply-To: <20060807204241.GA11510@kroah.com>
On Mon, Aug 07, 2006 at 01:42:41PM -0700, Greg KH wrote:
> On Mon, Aug 07, 2006 at 09:27:09PM +0200, Sam Ravnborg wrote:
> > Hi Greg.
> > Please apply to 2.6.18.
> >
> > Pull from:
> >
> > git://git.kernel.org/pub/scm/linux/kernel/git/sam/kbuild-2.6.18.git
>
> Thanks, pulled and pushed out.
>
> Oh, I just got a few reports of 2.6.18-rc3 not building with external
> trees very well, and something like the following would be required:
>
> --- linux-2.6.17/arch/sh/Makefile-dist 2006-08-07 20:42:33.000000000 +0200
> +++ linux-2.6.17/arch/sh/Makefile 2006-08-07 21:08:26.000000000 +0200
> @@ -173,7 +173,7 @@
> archprepare: maketools include/asm-sh/.cpu include/asm-sh/.mach
>
> PHONY += maketools FORCE
> -maketools: include/linux/version.h FORCE
> +maketools: $(objtree)/include/linux/version.h FORCE
>
> for all instances of the version.h file.
This looks bogus.
Current directory is $(objtree) so prefixing with $(objtree) should not
be needed and doing so will confuse make. make will not know that
$(objtree)/include/linux/version.h and include/linux/version.h is the
same file.
And the version.h dependency is anyway not needed. kbuild guarantee the
version.h is created when the commands for archprepare are executed.
So for sh I would expect the following is a better fix:
diff --git a/arch/sh/Makefile b/arch/sh/Makefile
index e467a45..ed1c865 100644
--- a/arch/sh/Makefile
+++ b/arch/sh/Makefile
@@ -172,8 +172,8 @@ include/asm-sh/.mach: $(wildcard include
archprepare: maketools include/asm-sh/.cpu include/asm-sh/.mach
-PHONY += maketools FORCE
-maketools: include/linux/version.h FORCE
+PHONY += maketools
+maketools: FORCE
$(Q)$(MAKE) $(build)=arch/sh/tools include/asm-sh/machtypes.h
all: zImage
arm should have a similar fix - thats the only other archtecture that
reference version.h in the arch specific kbuild (Makefile) files.
>
> Was this fixed in -rc4 and I should update the SuSE kernel to it (well,
> I'll do that anyway later today...), or is this something that you did
> not know about?
Have not seen the reports - may have overlookd them at lkml.
Been on vacation a few days so ctrl-d was used to read most of my
lkml mails.
Sam
next prev parent reply other threads:[~2006-08-07 21:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-07 19:27 [GIT PATCH] kbuild fixes for 2.6.18 Sam Ravnborg
2006-08-07 20:42 ` Greg KH
2006-08-07 21:02 ` Sam Ravnborg [this message]
2006-08-07 21:06 ` arm + sh cross compile suite for amd64 (i386)? Sam Ravnborg
2006-08-07 22:23 ` Andrew Morton
2006-08-07 21:20 ` [GIT PATCH] kbuild fixes for 2.6.18 Greg KH
2006-08-08 8:45 ` Takashi Iwai
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060807210209.GA14327@mars.ravnborg.org \
--to=sam@ravnborg.org \
--cc=akpm@osdl.org \
--cc=greg@kroah.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox