Re: [PATCH] x86_64: Auto size the per cpu area.

Eric W. Biederman
2006-08-08T06:46:45Z

Andi Kleen <ak@suse.de> writes:

> On Tuesday 08 August 2006 07:47, Eric W. Biederman wrote:
>>
>> Now for a completely different but trivial approach.
>> I just boot tested it with 255 CPUS and everything worked.
>>
>> Currently everything (except module data) we place in
>> the per cpu area we know about at compile time. So
>> instead of allocating a fixed size for the per_cpu area
>> allocate the number of bytes we need plus a fixed constant
>> for to be used for modules.
>>
>> It isn't perfect but it is much less of a pain to
>> work with than what we are doing now.
>
> Yes makes sense.
>
> However not that particular patch - i already changed that
> code in my tree because I needed really early per cpu for something and
> i had switched to using a static array for cpu0's cpudata.
>
> I will modify it to work like your proposal.

Sounds good to me.

Eric