Re: [PATCH] x86_64: Make NR_IRQS configurable in Kconfig

Eric W. Biederman
2006-08-07T18:17:34Z

"Randy.Dunlap" <rdunlap@xenotime.net> writes:

>>
>> This of course applies to the -mm tree because the rest
>> of the irq work is not yet in the mainline kernel.
>>
>> arch/x86_64/Kconfig | 14 ++++++++++++++
>> include/asm-x86_64/irq.h | 3 ++-
>> 2 files changed, 16 insertions(+), 1 deletions(-)
>>
>> diff --git a/arch/x86_64/Kconfig b/arch/x86_64/Kconfig
>> index 7598d99..cea78d7 100644
>> --- a/arch/x86_64/Kconfig
>> +++ b/arch/x86_64/Kconfig
>> @@ -384,6 +384,20 @@ config NR_CPUS
>> This is purely to save memory - each supported CPU requires
>> memory in the static kernel configuration.
>
> Thanks for the language fixes.
> I'm confused about one thing. What is NR_IRQS for non-SMP?
> Does it default to 4096 or something else?

Right the default is still 4096 which is fairly silly.

> Does this build on non-SMP? Is CONFIG_NR_IRQS defined for non-SMP?

Ugh. I have a "depends on SMP" line in there. That shouldn't be.
Ok. I need to fix the non SMP case, at least take out the dependency
and if I'm clever move the default down to 224.

Eric