From: Magnus Damm <magnus@valinux.co.jp>
To: linux-kernel@vger.kernel.org
Cc: Magnus Damm <magnus@valinux.co.jp>,
fastboot@lists.osdl.org, ebiederm@xmission.com
Subject: [PATCH] CONFIG_RELOCATABLE modpost fix
Date: Tue, 8 Aug 2006 17:32:11 +0900 (JST) [thread overview]
Message-ID: <20060808083307.391.45887.sendpatchset@cherry.local> (raw)
CONFIG_RELOCATABLE modpost fix
Run modpost on vmlinux regardless of CONFIG_MODULES. The modpost code is also
extended to ignore references from ".pci_fixup" to ".init.text".
Signed-off-by: Magnus Damm <magnus@valinux.co.jp>
---
This patch applies on top of Eric W. Biedermans CONFIG_RELOCATABLE tree
Makefile | 1 +
scripts/Makefile | 4 ++--
scripts/Makefile.modpost | 6 +++++-
scripts/mod/modpost.c | 14 +++++++++++---
--- 0001/Makefile
+++ work/Makefile 2006-08-07 13:11:44.000000000 +0900
@@ -723,6 +723,7 @@ endif # ifdef CONFIG_KALLSYMS
# vmlinux image - including updated kernel symbols
vmlinux: $(vmlinux-lds) $(vmlinux-init) $(vmlinux-main) $(kallsyms.o) FORCE
$(call if_changed_rule,vmlinux__)
+ $(Q)$(MAKE) -rR -f $(srctree)/scripts/Makefile.modpost __modpost_kernel
$(Q)rm -f .old_version
# The actual objects are generated when descending,
--- 0001/scripts/Makefile
+++ work/scripts/Makefile 2006-08-07 13:09:47.000000000 +0900
@@ -16,7 +16,7 @@ hostprogs-$(CONFIG_IKCONFIG) += bin2
always := $(hostprogs-y)
subdir-$(CONFIG_MODVERSIONS) += genksyms
-subdir-$(CONFIG_MODULES) += mod
+subdir-y += mod
# Let clean descend into subdirs
-subdir- += basic kconfig package
+subdir- += basic kconfig package mod
--- 0001/scripts/Makefile.modpost
+++ work/scripts/Makefile.modpost 2006-08-07 13:10:44.000000000 +0900
@@ -61,7 +61,11 @@ quiet_cmd_modpost = MODPOST
$(filter-out FORCE,$^)
PHONY += __modpost
-__modpost: $(wildcard vmlinux) $(modules:.ko=.o) FORCE
+__modpost: $(modules:.ko=.o) FORCE
+ $(call cmd,modpost)
+
+PHONY += __modpost_kernel
+__modpost_kernel: $(wildcard vmlinux) FORCE
$(call cmd,modpost)
# Declare generated files as targets for modpost
--- 0001/scripts/mod/modpost.c
+++ work/scripts/mod/modpost.c 2006-08-07 16:45:30.000000000 +0900
@@ -581,8 +581,8 @@ static int strrcmp(const char *s, const
* fromsec = .data
* atsym = *driver, *_template, *_sht, *_ops, *_probe, *probe_one
**/
-static int secref_whitelist(const char *tosec, const char *fromsec,
- const char *atsym)
+static int secref_whitelist(const char *modname, const char *tosec,
+ const char *fromsec, const char *atsym)
{
int f1 = 1, f2 = 1;
const char **s;
@@ -596,6 +596,13 @@ static int secref_whitelist(const char *
NULL
};
+ /* Ignore all references from .pci_fixup section if vmlinux */
+ if (strcmp(modname, "vmlinux") == 0) {
+ if ((strcmp(fromsec, ".pci_fixup") == 0) &&
+ (strcmp(tosec, ".init.text") == 0))
+ return 1;
+ }
+
/* Check for pattern 1 */
if (strcmp(tosec, ".init.data") != 0)
f1 = 0;
@@ -726,7 +733,8 @@ static void warn_sec_mismatch(const char
/* check whitelist - we may ignore it */
if (before &&
- secref_whitelist(secname, fromsec, elf->strtab + before->st_name))
+ secref_whitelist(modname, secname, fromsec,
+ elf->strtab + before->st_name))
return;
if (before && after) {
next reply other threads:[~2006-08-08 8:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-08 8:32 Magnus Damm [this message]
2006-08-08 15:16 ` [PATCH] CONFIG_RELOCATABLE modpost fix Sam Ravnborg
2006-08-09 1:12 ` Magnus Damm
2006-08-08 18:39 ` Sam Ravnborg
2006-08-08 19:59 ` Eric W. Biederman
2006-08-08 22:05 ` Sam Ravnborg
2006-08-09 1:32 ` Magnus Damm
2006-08-09 6:29 ` Sam Ravnborg
2006-08-09 7:06 ` Magnus Damm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060808083307.391.45887.sendpatchset@cherry.local \
--to=magnus@valinux.co.jp \
--cc=ebiederm@xmission.com \
--cc=fastboot@lists.osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox