From: Andi Kleen <ak@suse.de>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Andrew Morton <akpm@osdl.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.6.18-rc3-mm2] KPROBE_ENTRY ends up putting code into .fixup
Date: Wed, 9 Aug 2006 04:13:54 +0200 [thread overview]
Message-ID: <200608090413.54286.ak@suse.de> (raw)
In-Reply-To: <44D937EE.1020404@goop.org>
On Wednesday 09 August 2006 03:18, Jeremy Fitzhardinge wrote:
> KPROBE_ENTRY does a .section .kprobes.text, and expects its users to
> do a .previous at the end of the function.
>
> Unfortunately, if any code within the function switches sections, for
> example .fixup, then the .previous ends up putting all subsequent code
> into .fixup. Worse, any subsequent .fixup code gets intermingled with
> the code its supposed to be fixing (which is also in .fixup). It's
> surprising this didn't cause more havok.
>
> The fix is to use .pushsection/.popsection, so this stuff nests
> properly. A further cleanup would be to get rid of all
> .section/.previous pairs, since they're inherently fragile.
Added thanks.
-Andi
prev parent reply other threads:[~2006-08-09 2:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 1:18 [PATCH 2.6.18-rc3-mm2] KPROBE_ENTRY ends up putting code into .fixup Jeremy Fitzhardinge
2006-08-09 2:13 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608090413.54286.ak@suse.de \
--to=ak@suse.de \
--cc=akpm@osdl.org \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox