From: Andi Kleen <ak@suse.de>
To: john stultz <johnstul@us.ibm.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [RFC][PATCH 1/6] x86_64: Enable arch-generic vsyscall support.
Date: Wed, 9 Aug 2006 04:59:05 +0200 [thread overview]
Message-ID: <200608090459.05028.ak@suse.de> (raw)
In-Reply-To: <1155092218.13030.107.camel@cog.beaverton.ibm.com>
On Wednesday 09 August 2006 04:56, john stultz wrote:
> On Wed, 2006-08-09 at 04:29 +0200, Andi Kleen wrote:
> > > diff --git a/kernel/timer.c b/kernel/timer.c
> > > index b650f04..08b4a02 100644
> > > --- a/kernel/timer.c
> > > +++ b/kernel/timer.c
> > > @@ -1023,6 +1023,12 @@ static int __init timekeeping_init_devic
> > >
> > > device_initcall(timekeeping_init_device);
> > >
> > > +#ifdef CONFIG_GENERIC_TIME_VSYSCALL
> > > +extern void update_vsyscall(struct timespec* ts, struct clocksource* c);
> > > +#else
> > > +#define update_vsyscall(now, c)
> > > +#endif
> >
> > Using a weak dummy function would be a bit cleaner.
>
> Will compilers optimize out the call properly?
No, but it's just a call ; ret then.
>
> Looking at it now, it probably should go in a .h file and the empty
> define should be a proper "do { } while(0)"
Or use weak
-Andi
next prev parent reply other threads:[~2006-08-09 2:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 2:17 [RFC][PATCH 0/6] x86_64: Generic timekeeping for x86_64 john stultz
2006-08-09 2:17 ` [RFC][PATCH 1/6] x86_64: Enable arch-generic vsyscall support john stultz
2006-08-09 2:29 ` Andi Kleen
2006-08-09 2:56 ` john stultz
2006-08-09 2:59 ` Andi Kleen [this message]
2006-08-09 2:17 ` [RFC][PATCH 2/6] x86_64: hpet_address cleanup john stultz
2006-08-09 2:31 ` Andi Kleen
2006-08-09 3:08 ` john stultz
2006-08-09 2:17 ` [RFC][PATCH 3/6] x86_64: Remove apic_runs_main_timer john stultz
2006-08-09 2:31 ` Andi Kleen
2006-08-09 2:17 ` [RFC][PATCH 4/6] x86_64: Enable CONFIG_GENERIC_TIME john stultz
2006-08-09 2:17 ` [RFC][PATCH 5/6] x86_64: Clocksources for x86-64 john stultz
2006-08-09 2:41 ` Andi Kleen
2006-08-09 3:41 ` john stultz
2006-08-09 2:17 ` [RFC][PATCH 6/6] x86_64: GENERIC_TIME based vsyscall code john stultz
2006-08-09 2:45 ` Andi Kleen
2006-08-09 2:41 ` [RFC][PATCH 0/6] x86_64: Generic timekeeping for x86_64 Andi Kleen
2006-08-09 2:48 ` john stultz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608090459.05028.ak@suse.de \
--to=ak@suse.de \
--cc=johnstul@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox