Re: [PATCH] ftdi_sio driver - new PIDs

Greg KH
2006-08-04T17:23:49Z

On Fri, Aug 04, 2006 at 03:34:25PM +0100, Jonathan Davies wrote:
> Hello,
>
> I have come across some USB Serial FTDI-based devices which are not
> automatically detected by ftdi_sio, as of Linux 2.6.17, because their
> Product IDs are not recognised by the driver.
>
> The devices are:
>
> 1. AlphaMicro Components AMC-232USB01 (serial to USB converter cable)
> - http://www.alphamicro.net/components/product~line~4~id~224.asp
> - vendor ID 0x0403
> - product ID 0xff00
>
> 2. Lawicel CANUSB (CAN bus to USB converter dongle)
> - http://www.canusb.com/
> - vendor ID 0x0403
> - product ID 0xffa8
>
> Below is the patch for drivers/usb/serial/ftdi_sio.{c,h} against Linux
> 2.6.17 which includes these Product IDs.
>
> Signed-off-by: Jonathan Davies <jjd27@cam.ac.uk>
>
>
> diff -uprN -X dontdiff linux-vanilla/drivers/usb/serial/ftdi_sio.c
> linux-2.6.17/drivers/usb/serial/ftdi_sio.c
> --- linux-vanilla/drivers/usb/serial/ftdi_sio.c 2006-08-04
> 15:12:02.000000000 +0100
> +++ linux-2.6.17/drivers/usb/serial/ftdi_sio.c 2006-08-04
> 15:07:43.000000000 +0100

Your patch is line-wrapped and the tabs are eaten, making it hard to
apply the patch :(

Also, can you make this against the 2.6.18-rc3 kernel, as there are a
lot of new ids already added for this device and this patch conflicts
with it a bit.

> @@ -17,6 +17,9 @@
> * See http://ftdi-usb-sio.sourceforge.net for upto date testing info
> * and extra documentation
> *
> + * (04/Aug/2006) Jonathan Davies
> + * Added PIDs for AMC232 and Lawicel CANUSB.
> + *

This section isn't needed anymore, the git changelog is all that is
used now.

thanks,

greg k-h