From: "Rafael J. Wysocki" <rjw@sisk.pl>
To: Pavel Machek <pavel@suse.cz>
Cc: LKML <linux-kernel@vger.kernel.org>, Linux PM <linux-pm@osdl.org>
Subject: Re: [RFC][PATCH -mm 3/5] swsusp: Fix handling of highmem
Date: Wed, 9 Aug 2006 14:07:19 +0200 [thread overview]
Message-ID: <200608091407.19845.rjw@sisk.pl> (raw)
In-Reply-To: <20060809115145.GT3308@elf.ucw.cz>
Hi,
On Wednesday 09 August 2006 13:51, Pavel Machek wrote:
> > Make swsusp handle highmem pages similarly to the pages of the "normal"
> > memory.
>
> Is it feasible to create kernel/power/highmem.c?
Not really ...
> > include/linux/suspend.h | 6
> > kernel/power/power.h | 2
> > kernel/power/snapshot.c | 822 ++++++++++++++++++++++++++++++++++++------------
> > kernel/power/swap.c | 2
> > kernel/power/swsusp.c | 53 +--
> > kernel/power/user.c | 2
> > mm/vmscan.c | 3
> > 7 files changed, 658 insertions(+), 232 deletions(-)
>
> +400 lines for highmem... I hope highmem dies, dies, dies. Anyway, I'd
> hate to debug this at the same time as the bitmap code. Can we get the
> bitmaps in, wait for a while, and only then change highmem handling?
Sure, why not. I'll prepare a series without the highmem patch for now.
Rafael
next prev parent reply other threads:[~2006-08-09 12:08 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-09 9:52 [RFC][PATCH -mm 0/5] swsusp: Fix handling of highmem Rafael J. Wysocki
2006-08-09 9:58 ` [RFC][PATCH -mm 1/5] swsusp: Introduce memory bitmaps Rafael J. Wysocki
2006-08-09 10:31 ` Pavel Machek
2006-08-09 10:57 ` Rafael J. Wysocki
2006-08-09 11:27 ` Pavel Machek
2006-08-09 11:36 ` Rafael J. Wysocki
2006-08-09 11:53 ` Pavel Machek
2006-08-09 12:11 ` Rafael J. Wysocki
2006-08-09 11:46 ` Pavel Machek
2006-08-09 12:02 ` Rafael J. Wysocki
2006-08-09 13:35 ` Pavel Machek
2006-08-09 10:04 ` [RFC][PATCH -mm 2/5] swsusp: Use memory bitmaps during resume Rafael J. Wysocki
2006-08-09 10:34 ` Pavel Machek
2006-08-09 11:04 ` Rafael J. Wysocki
2006-08-09 11:33 ` Pavel Machek
2006-08-09 11:51 ` Rafael J. Wysocki
2006-08-09 13:33 ` Pavel Machek
2006-08-09 11:49 ` Pavel Machek
2006-08-09 12:04 ` Rafael J. Wysocki
2006-08-09 12:10 ` Pavel Machek
2006-08-09 10:09 ` [RFC][PATCH -mm 3/5] swsusp: Fix handling of highmem Rafael J. Wysocki
2006-08-09 11:51 ` Pavel Machek
2006-08-09 12:07 ` Rafael J. Wysocki [this message]
2006-08-09 13:35 ` Pavel Machek
2006-08-09 10:11 ` [RFC][PATCH -mm 4/5] swsusp: Change the name of pagedir_nosave Rafael J. Wysocki
2006-08-09 10:35 ` Pavel Machek
2006-08-09 10:13 ` [RFC][PATCH -mm 5/5] swsusp: Introduce some helpful constants Rafael J. Wysocki
2006-08-09 10:36 ` Pavel Machek
2006-08-09 10:47 ` [RFC][PATCH -mm 0/5] swsusp: Fix handling of highmem Nigel Cunningham
2006-08-09 11:38 ` Pavel Machek
2006-08-09 11:52 ` Nigel Cunningham
2006-08-13 22:34 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608091407.19845.rjw@sisk.pl \
--to=rjw@sisk.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@osdl.org \
--cc=pavel@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox