Re: [PATCH 5/6] clean up OCFS2 nlink handling

Christoph Hellwig
2006-08-09T17:12:57Z

On Wed, Aug 09, 2006 at 09:57:33AM -0700, Dave Hansen wrote:
>
> OCFS2 does some operations on i_nlink, then reverts them if some
> of its operations fail to complete. This does not fit in well
> with the drop_nlink() logic where we expect i_nlink to stay at
> zero once it gets there.
>
> So, delay all of the nlink operations until we're sure that the
> operations have completed. Also, introduce a small helper to
> check whether an inode has proper "unlinkable" i_nlink counts
> no matter whether it is a directory or regular inode.
>
> This patch is broken out from the others because it does contain
> some logical changes.

looks good to me, although I probably can't ACK ocfs2 patches. did you
look whether gfs2 in -mm needs something similar?