Re: [PATCH 3/6] unlink: monitor i_nlink

Christoph Hellwig
2006-08-09T17:11:15Z

On Wed, Aug 09, 2006 at 09:57:32AM -0700, Dave Hansen wrote:
>
> When a filesystem decrements i_nlink to zero, it means that a
> write must be performed in order to drop the inode from the
> filesystem.
>
> We're shortly going to have keep filesystems from being remounted
> r/o between the time that this i_nlink decrement and that write
> occurs.
>
> So, add a little helper function to do the decrements. We'll
> tie into it in a bit to note when i_nlink hits zero.
>
> Signed-off-by: Dave Hansen <haveblue@us.ibm.com>

Acked-by: Christoph Hellwig <hch@lst.de>

Note that we all (and especially Andrew :)) need to be carefull not to
introduce unguarded i_nlink decrements again. Dave, you'll probably need
to do another audit when you introduce the real functionality.