Re: Adrian Bunk is now taking over the 2.6.16-stable branch

Adrian Bunk
2006-08-12T16:24:50Z

On Thu, Aug 10, 2006 at 01:57:13PM +0200, Stefan Richter wrote:
> Adrian Bunk wrote:
> ...
> > I'm currently
> > going through all 2.6.17.7 and 2.6.17.8 patches looking for patches I
> > should apply.
>
> Suggested updates for drivers/ieee1394/:
>
> (from 2.6.17.2)
> Fix broken suspend/resume in ohci1394
> should be applicable as-is. This does not add full suspend/resume
> functionality to ohci1394 but it fixes fatal side effects on other
> on-board hardware after resume.
>
> (from 2.6.17.8)
> ieee1394: sbp2: enable auto spin-up for Maxtor disks
> doesn't apply to 2.6.16 as-is.
> https://bugzilla.novell.com/show_bug.cgi?id=183011#c6 has an adapted
> version. I will mail it to you with proper description and signed-off-by
> later today. While I am at it, I will resend that ohci1394 patch too.

Thanks, I've applied them both.

> I have a related question about your plans with Linux 2.6.16.yy.
> Documentation/stable_kernel_rules.txt says:
>
> - It must fix a problem that causes a build error (but not for things
> marked CONFIG_BROKEN), an oops, a hang, data corruption, a real
> security issue, or some "oh, that's not good" issue. In short,
> something critical.
>
> I plan to submit a patch of the kind "fix recognition of a quirky
> device" for 2.6.18. That patch does not fix an oops, hang, data
> corruption, or security hole. (The patch will fulfill all other criteria
> from stable_kernel_rules.) Do you consider "can't use that shiny device
> under Linux" as "oh, that's not good" in the context of Linux 2.6.16.yy?
>...

If the device doesn't work, it's an "oh, that's not good" issue. ;-)

More seriously:

I consider stable_kernel_rules.txt as a more formal description of
"avoid regressions".

If the patch is tested, unlikely to break anything and included in
Linus' tree it's a candidate for 2.6.16.

> Stefan Richter

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed