From: Russell King <rmk+lkml@arm.linux.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Cc: Linux Kernel List <linux-kernel@vger.kernel.org>,
Arjan Van de Ven <arjan@infradead.org>,
Ingo Molnar <mingo@elte.hu>, Nicolas Pitre <nico@cam.org>
Subject: Re: lockdep: fix smc91x
Date: Thu, 10 Aug 2006 00:29:13 +0100 [thread overview]
Message-ID: <20060809232912.GA29587@flint.arm.linux.org.uk> (raw)
In-Reply-To: <44D95A58.6070706@garzik.org>
On Tue, Aug 08, 2006 at 11:45:28PM -0400, Jeff Garzik wrote:
> Russell King wrote:
> >Hi,
> >
> >When booting using root-nfs, I'm seeing (independently) two lockdep dumps
> >in the smc91x driver. The patch below fixes both. Both dumps look like
> >real locking issues.
> >
> >Nico - please review and ack if you think the patch is correct.
>
> Was this ever ACK'd?
Not afaik.
> I would prefer spin_lock_irqsave(), but that's just a quibble. I would
> be OK with applying this.
Yes, though I did review all call paths to make sure it was safe first.
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
prev parent reply other threads:[~2006-08-09 23:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-27 14:44 lockdep: fix smc91x Russell King
2006-08-09 3:45 ` Jeff Garzik
2006-08-09 23:29 ` Russell King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060809232912.GA29587@flint.arm.linux.org.uk \
--to=rmk+lkml@arm.linux.org.uk \
--cc=arjan@infradead.org \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=nico@cam.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox