public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: Miklos Szeredi <miklos@szeredi.hu>
Cc: zam@namesys.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fuse: fix error case in fuse_readpages
Date: Thu, 10 Aug 2006 02:00:09 -0700	[thread overview]
Message-ID: <20060810020009.da64e461.akpm@osdl.org> (raw)
In-Reply-To: <E1GB6Ax-0002Wn-00@dorka.pomaz.szeredi.hu>

On Thu, 10 Aug 2006 10:45:59 +0200
Miklos Szeredi <miklos@szeredi.hu> wrote:

> > > Thanks Alex.
> > > 
> > > -mm also needs s/page_cache_release/read_cache_pages_release_page/ on patch
> > > 
> > > --
> > > From: Alexander Zarochentsev <zam@namesys.com>
> > > 
> > > Don't let fuse_readpages leave the @pages list not empty when exiting
> > > on error.
> > > 
> > 
> > hm, OK.
> > 
> > > +extern void readpages_cleanup_helper(struct list_head *);
> > 
> > Can we think of a better name?  I mean, all it does is throw away a list of
> > pages.  The caller doesn't _have_ to be using it within the context of
> > read_cache_pages().  put_pages()?  put_pages_list()?
> 
> So what's up with read_cache_pages_release_page() in -mm, which seems
> to be rather specific to read_cache_pages()?
> 

That's part of the readahead patches.  Don't look at that ;)

      reply	other threads:[~2006-08-10  9:00 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-10  7:57 [PATCH] fuse: fix error case in fuse_readpages Miklos Szeredi
2006-08-10  8:10 ` Andrew Morton
2006-08-10  8:45   ` Miklos Szeredi
2006-08-10  9:00     ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060810020009.da64e461.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=miklos@szeredi.hu \
    --cc=zam@namesys.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox