From: Andrew Morton <akpm@osdl.org>
To: Theodore Tso <tytso@mit.edu>
Cc: cmm@us.ibm.com, linux-fsdevel@vger.kernel.org,
ext2-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [Ext2-devel] [PATCH 1/9] extents for ext4
Date: Thu, 10 Aug 2006 11:00:47 -0700 [thread overview]
Message-ID: <20060810110047.af273a55.akpm@osdl.org> (raw)
In-Reply-To: <20060810171755.GA19238@thunk.org>
On Thu, 10 Aug 2006 13:17:55 -0400
Theodore Tso <tytso@mit.edu> wrote:
> On Wed, Aug 09, 2006 at 11:39:40PM -0700, Andrew Morton wrote:
> > - replace all brelse() calls with put_bh(). Because brelse() is
> > old-fashioned, has a weird name and neelessly permits a NULL arg.
> >
> > In fact it would be beter to convert JBD and ext3 to put_bh before
> > copying it all over.
>
> Wouldn't it be better to preserve in the source code history the
> brelse->put_bh conversion? We can pour a huge number of changes in
> ext4 before we submit, but I would have thought it would be easier for
> everyone to see what is going on if we submit with just the minimal
> changes, and then have patches that address concerns like this one at
> a time.
>
I'd suggest that this be one of the cleanups which be done within ext3
before taking the ext4 copy.
That's assuming we want to do the spring-cleaning - we might of course
decide not to. But it'd be a good time to do so.
next prev parent reply other threads:[~2006-08-10 18:04 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-10 1:20 [PATCH 1/9] extents for ext4 Mingming Cao
2006-08-10 6:39 ` Andrew Morton
2006-08-10 9:29 ` [Ext2-devel] " Alex Tomas
2006-08-10 9:48 ` Andrew Morton
2006-08-10 10:08 ` Alex Tomas
2006-08-10 15:55 ` Zach Brown
2006-08-10 17:49 ` Randy.Dunlap
2006-08-10 19:05 ` Alex Tomas
2006-08-11 20:57 ` Randy.Dunlap
2006-08-11 21:05 ` Alex Tomas
2006-08-11 21:49 ` Mingming Cao
2006-08-11 23:00 ` Andrew Morton
2006-08-12 6:02 ` Randy.Dunlap
2006-08-12 17:43 ` Darrick J. Wong
2006-08-12 18:20 ` Randy.Dunlap
2006-08-14 16:26 ` Mingming Cao
2006-08-14 17:22 ` Randy.Dunlap
2006-08-14 17:52 ` Jeff Garzik
2006-08-14 18:05 ` Randy.Dunlap
2006-08-14 18:13 ` Jeff Garzik
2006-08-15 15:40 ` Pavel Machek
2006-08-18 13:08 ` Andreas Dilger
2006-08-10 16:46 ` Mingming Cao
2006-08-10 17:17 ` [Ext2-devel] " Theodore Tso
2006-08-10 18:00 ` Andrew Morton [this message]
2006-08-11 22:13 ` Mingming Cao
2006-08-11 23:16 ` Andrew Morton
2006-08-12 0:05 ` [PATCH 1/2] ext3 and jbd cleanup: remove whitespace Mingming Cao
2006-08-12 0:05 ` [PATCH 2/2] ext3 and jbd cleanup: replace brelse() to put_bh Mingming Cao
-- strict thread matches above, loose matches on Subject: below --
2006-08-15 21:27 [Ext2-devel] [PATCH 1/9] extents for ext4 Randy Dunlap
2006-08-15 23:19 ` Mingming Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060810110047.af273a55.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=cmm@us.ibm.com \
--cc=ext2-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox