Re: [PATCH 2/9] sector_t format string

Jeff Mahoney
2006-08-11T14:44:46Z

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Jan Engelhardt wrote:
>>> Will
>>>
>>> printk("%S", sector_t);
>>>
>>> kill at least one kitten?
>> I like the general idea. I think that having to cast every time you want
>> to print a sector number is pretty gross. I had something more like %Su
>> in mind, though.
>
> What will happen if you run out of %[a-z] ?

Are we really expecting that many global structure members to be
variable width? I only propose adding another option because whenever a
sector is printed, it must be casted to avoid warnings.

Other replies commented on how gcc won't recognize the new option, so
we'd receive warnings anyway. Cleaner code that causes warnings doesn't
sound like a big win after all.

- -Jeff

- --
Jeff Mahoney
SUSE Labs
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (GNU/Linux)
Comment: Using GnuPG with SUSE - http://enigmail.mozdev.org

iD8DBQFE3Ji1LPWxlyuTD7IRApAEAJ9ApkoyKwmTReZindjJmkuU/0yhbACgk0Uu
zG8eXN3RzU1wKFVrRlr3xO8=
=e6D2
-----END PGP SIGNATURE-----