From: Yasunori Goto <y-goto@jp.fujitsu.com>
To: akpm@osdl.org, "Brown, Len" <len.brown@intel.com>
Cc: keith mannthey <kmannth@us.ibm.com>,
ACPI-ML <linux-acpi@vger.kernel.org>,
Linux Kernel ML <linux-kernel@vger.kernel.org>,
Linux Hotplug Memory Support <lhms-devel@lists.sourceforge.net>
Subject: [PATCH](memory hotplug) Repost remove useless message at boot time from 2.6.18-rc4.
Date: Thu, 10 Aug 2006 14:32:11 +0900 [thread overview]
Message-ID: <20060810142329.EB03.Y-GOTO@jp.fujitsu.com> (raw)
In-Reply-To: <20060804213230.D5D4.Y-GOTO@jp.fujitsu.com>
Hello.
I would like to repost this patch to remove noisy useless message at boot
time from 2.6.18-rc4.
(I said "-mm doesn't shows this message in previous post", but it was wrong.
This messages are shown by -mm too.)
-------------------------
This is to remove noisy useless message at boot time from 2.6.18-rc4.
The message is a ton of
"ACPI Exception (acpi_memory-0492): AE_ERROR, handle is no memory device"
In my emulation, number of memory devices are not so many (only 6),
but, this messages are displayed 114 times.
It is showed by acpi_memory_register_notify_handler() which
is called by acpi_walk_namespace().
acpi_walk_namespace() parses all of ACPI's namespace and
execute acpi_memory_register_notify_handler(). So, it is called for
all of the device which is defined in namespace. If
the parsing device is not memory, acpi_memhotplug ignores it
due to "no match" and will parse next device.
This is normal route.
But this message says it is exception. It is meaningless.
I tested this patch for 2.6.18-rc4 on my box with hot-add emulation.
Please apply.
Signed-off-by: Yasunori Goto <y-goto@jp.fujitsu.com>
------
drivers/acpi/acpi_memhotplug.c | 8 ++------
1 files changed, 2 insertions(+), 6 deletions(-)
Index: rc4test/drivers/acpi/acpi_memhotplug.c
===================================================================
--- rc4test.orig/drivers/acpi/acpi_memhotplug.c 2006-08-09 15:33:29.000000000 +0900
+++ rc4test/drivers/acpi/acpi_memhotplug.c 2006-08-09 16:26:29.000000000 +0900
@@ -484,10 +484,8 @@ acpi_memory_register_notify_handler(acpi
status = is_memory_device(handle);
- if (ACPI_FAILURE(status)){
- ACPI_EXCEPTION((AE_INFO, status, "handle is no memory device"));
+ if (ACPI_FAILURE(status))
return AE_OK; /* continue */
- }
status = acpi_install_notify_handler(handle, ACPI_SYSTEM_NOTIFY,
acpi_memory_device_notify, NULL);
@@ -503,10 +501,8 @@ acpi_memory_deregister_notify_handler(ac
status = is_memory_device(handle);
- if (ACPI_FAILURE(status)){
- ACPI_EXCEPTION((AE_INFO, status, "handle is no memory device"));
+ if (ACPI_FAILURE(status))
return AE_OK; /* continue */
- }
status = acpi_remove_notify_handler(handle,
ACPI_SYSTEM_NOTIFY,
--
Yasunori Goto
next prev parent reply other threads:[~2006-08-10 5:32 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-04 12:37 [PATCH](memory hotplug) remove useless message at boot time from 2.6.18-rc3 Yasunori Goto
2006-08-10 5:32 ` Yasunori Goto [this message]
2006-08-10 20:26 ` [PATCH](memory hotplug) Repost remove useless message at boot time from 2.6.18-rc4 Prarit Bhargava
2006-08-10 20:54 ` Len Brown
2006-08-10 20:55 ` Prarit Bhargava
2006-08-15 12:03 ` Thomas Renninger
2006-08-15 21:36 ` Yasunori Goto
2006-08-25 11:59 ` Yasunori Goto
2006-08-27 12:50 ` Thomas Renninger
2006-08-28 14:12 ` Yasunori Goto
2006-08-28 21:16 ` Thomas Renninger
2006-08-29 1:57 ` Yasunori Goto
2006-08-31 22:22 ` Bjorn Helgaas
2006-08-27 15:19 ` [PATCH 2/2] ACPI memory_hotplug cleanups Thomas Renninger
2006-08-27 17:19 ` [PATCH 1/2] acpi hotplug cleanups, move install notifier to add function Thomas Renninger
2006-08-30 21:48 ` keith mannthey
2006-08-27 17:58 ` [PATCH 2/2] " Thomas Renninger
2006-08-28 8:08 ` Yasunori Goto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060810142329.EB03.Y-GOTO@jp.fujitsu.com \
--to=y-goto@jp.fujitsu.com \
--cc=akpm@osdl.org \
--cc=kmannth@us.ibm.com \
--cc=len.brown@intel.com \
--cc=lhms-devel@lists.sourceforge.net \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox