From: Andi Kleen <ak@suse.de>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: "Jan Beulich" <jbeulich@novell.com>,
linux-kernel@vger.kernel.org, stsp@aknet.ru
Subject: Re: [patch] i386: annotate the rest of entry.s::nmi
Date: Thu, 10 Aug 2006 14:58:45 +0200 [thread overview]
Message-ID: <200608101458.45683.ak@suse.de> (raw)
In-Reply-To: <200608100851_MC3-1-C7A8-8B6A@compuserve.com>
On Thursday 10 August 2006 14:48, Chuck Ebbert wrote:
> In-Reply-To: <44DB0927.76E4.0078.0@novell.com>
>
> On Thu, 10 Aug 2006 10:23:35 +0200, Jan Beulich wrote:
>
> > >Part of the NMI handler is missing annotations. Just moving
> > >the RING0_INT_FRAME macro fixes it. And additional comments
> > >should warn anyone changing this to recheck the annotations.
> >
> > I have to admit that I can't see the value of this movement; the
> > code sequence in question was left un-annotated intentionally.
> > The point is that the push-es in FIX_STACK() aren't annotated, so
> > things won't be correct at those points anyway.
>
> I have a patch here that adds that, but it won't compile
> because that part of the NMI handler is un-annotated:
Ok i dropped the original patch for now and you guys can work
out a correct fix.
-Andi
next prev parent reply other threads:[~2006-08-10 12:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-10 12:48 [patch] i386: annotate the rest of entry.s::nmi Chuck Ebbert
2006-08-10 12:58 ` Andi Kleen [this message]
2006-08-10 13:39 ` Jan Beulich
-- strict thread matches above, loose matches on Subject: below --
2006-08-11 23:13 Chuck Ebbert
2006-08-14 6:55 ` Jan Beulich
2006-08-10 17:39 Chuck Ebbert
2006-08-11 7:10 ` Jan Beulich
2006-08-10 4:59 Chuck Ebbert
2006-08-10 5:20 ` Andi Kleen
2006-08-10 8:23 ` Jan Beulich
2006-08-10 8:26 ` Andi Kleen
2006-08-10 8:34 ` Jan Beulich
2006-08-11 17:46 ` Stas Sergeev
2006-08-14 6:52 ` Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608101458.45683.ak@suse.de \
--to=ak@suse.de \
--cc=76306.1226@compuserve.com \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
--cc=stsp@aknet.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox