Re: [PATCH for review] [130/145] i386: clean up topology.c

Dave Hansen
2006-08-10T19:50:30Z

On Thu, 2006-08-10 at 21:37 +0200, Andi Kleen wrote:
> static int __init topology_init(void)
> {
> int i;
>
> +#ifdef CONFIG_NUMA
> for_each_online_node(i)
> register_one_node(i);
> +#endif /* CONFIG_NUMA */
>
> for_each_present_cpu(i)
> arch_register_cpu(i);
> return 0;
> }

Wouldn't it be more proper here to make register_one_node() have a
non-NUMA definition, instead of putting an #ifdef in a .c file like
this?

-- Dave