Re: [PATCH for review] [123/145] i386: make fault notifier unconditional and export it

Adrian Bunk
2006-08-13T15:29:02Z

> It's needed for external debuggers and overhead is very small.
>...

We are currently trying to remove exports not used by any in-kernel
code.

The patch description also lacks the name of what you call "external
debuggers" (I assume the exports are not for a theoretical usage but for
an already existing debugger?). There is no reason for keeping a patch
description small.

Especially nowadays where people demand deprecation periods for removing
exports without any in-kernel users there must be a _very_ good
justification when adding such exports.

This is true for both the i386 and the x86_64 patches.

cu
Adrian

BTW1: The subject of this email is wrong (it's the x86_64 patch).
BTW2: Please use a valid To: header.

--

Gentoo kernels are 42 times more popular than SUSE kernels among
KLive users (a service by SUSE contractor Andrea Arcangeli that
gathers data about kernels from many users worldwide).

There are three kinds of lies: Lies, Damn Lies, and Statistics.
Benjamin Disraeli