Re: [PATCH for review] [123/145] i386: make fault notifier unconditional and export it

Andi Kleen
2006-08-13T20:17:54Z

On Sunday 13 August 2006 17:28, Adrian Bunk wrote:
> > It's needed for external debuggers and overhead is very small.
> >...
>
> We are currently trying to remove exports not used by any in-kernel
> code.

That ``we'' doesn't include me at least.

>
> The patch description also lacks the name of what you call "external
> debuggers" (I assume the exports are not for a theoretical usage but for
> an already existing debugger?).

The fault chain is needed for pretty much any debugger, including
kgdb, kdb, nlkd. The one in this case was NLKD.

> Especially nowadays where people demand deprecation periods for removing
> exports without any in-kernel users there must be a _very_ good
> justification when adding such exports.

I've always exported symbols when people can make a reasonable case that they
need it for extern free non broken by design code.

On the other hand I have no problems with removing unused exports
that don't have such a case or are clearly not a useful external
interface.

> BTW1: The subject of this email is wrong (it's the x86_64 patch).

Fixed, thanks

-Andi