From: Andi Kleen <ak@suse.de>
To: Chuck Ebbert <76306.1226@compuserve.com>
Cc: linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH for review] [145/145] i386: Disallow kprobes on NMI handlers
Date: Fri, 11 Aug 2006 08:53:19 +0200 [thread overview]
Message-ID: <200608110853.19740.ak@suse.de> (raw)
In-Reply-To: <200608110240_MC3-1-C7C3-777A@compuserve.com>
On Friday 11 August 2006 08:37, Chuck Ebbert wrote:
> In-Reply-To: <20060810193745.DBBAA13B8E@wotan.suse.de>
>
> On Thu, 10 Aug 2006 21:37:45 +0200, Andi Kleen wrote:
>
> > --- linux.orig/arch/i386/kernel/entry.S
> > +++ linux/arch/i386/kernel/entry.S
> > @@ -725,7 +725,7 @@ debug_stack_correct:
> > * check whether we got an NMI on the debug path where the debug
> > * fault happened on the sysenter path.
> > */
> > -ENTRY(nmi)
> > +KPROBE_ENTRY(nmi)
> > RING0_INT_FRAME
> > pushl %eax
> > CFI_ADJUST_CFA_OFFSET 4
>
> Needs .popsection at the end of the NMI code.
This is fixed up in a later patch I think.
i386: KPROBE_ENTRY ends up putting code into .fixup
-andi
next prev parent reply other threads:[~2006-08-11 6:54 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-11 6:37 [PATCH for review] [145/145] i386: Disallow kprobes on NMI handlers Chuck Ebbert
2006-08-11 6:53 ` Andi Kleen [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-08-11 23:13 Chuck Ebbert
[not found] <20060810 935.775038000@suse.de>
2006-08-10 19:37 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200608110853.19740.ak@suse.de \
--to=ak@suse.de \
--cc=76306.1226@compuserve.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox