Re: [PATCH for review] [43/145] i386: Redo semaphore and rwlock assembly helpers

Andi Kleen
2006-08-13T07:45:59Z

On Sunday 13 August 2006 08:54, Andrew Morton wrote:
> On Sun, 13 Aug 2006 08:50:01 +0200
> Andi Kleen <ak@suse.de> wrote:
>
> > On Sunday 13 August 2006 02:53, Andrew Morton wrote:
> > > On Thu, 10 Aug 2006 21:35:57 +0200 (CEST)
> > > Andi Kleen <ak@suse.de> wrote:
> > >
> > > > - Move them to a pure assembly file. Previously they were in
> > > > a C file that only consisted of inline assembly. Doing it in pure
> > > > assembler is much nicer.
> > > > - Add a frame.i include with FRAME/ENDFRAME macros to easily
> > > > add frame pointers to assembly functions
> > > > - Add dwarf2 annotation to them so that the new dwarf2 unwinder
> > > > doesn't get stuck on them
> > > > [TBD: needs review from someone who knows more about CFA than me, e.g. Jan]
> > > > - Random cleanups
> > >
> > > This patch causes the below crash after some seconds of disk stresstesting.
> >
> > I can't reproduce this with either LTP nor OraSim.
> > Also I looked over the patch and i can't see any mistakes.
> >
> > Can you double check please?
> >
>
> 2-way pIII with the below .config crashes in seconds running LTP's

Ok fixed now.

On the second patch revision I added FRAMEs to the write lock functions too
and that was broken in the frame pointer case, which I didn't retest :/
Sorry. Fixed now on ff.

-Andi