From: Dave Jones <davej@redhat.com>
To: Thomas Koeller <thomas@koeller.dyndns.org>
Cc: wim@iguana.be, linux-kernel@vger.kernel.org,
Ralf Baechle <ralf@linux-mips.org>,
linux-mips@linux-mips.org
Subject: Re: [PATCH] Added MIPS RM9K watchdog driver
Date: Fri, 11 Aug 2006 20:06:36 -0400 [thread overview]
Message-ID: <20060812000636.GB28540@redhat.com> (raw)
In-Reply-To: <200608120149.23380.thomas@koeller.dyndns.org>
On Sat, Aug 12, 2006 at 01:49:23AM +0200, Thomas Koeller wrote:
> On Friday 11 August 2006 22:56, Dave Jones wrote:
> > On Thu, Aug 10, 2006 at 11:19:13PM +0200, thomas@koeller.dyndns.org wrote:
> > > This is a driver for the on-chip watchdog device found on some
> > > MIPS RM9000 processors.
> > >
> > > Signed-off-by: Thomas Koeller <thomas.koeller@baslerweb.com>
> >
> > Mostly same nit-picking comments as your other driver..
>
> Which one?
The image capture driver.
> > > +#include <linux/config.h>
> >
> > not needed.
>
> It is, otherwise I do not get CONFIG_WATCHDOG_NOWAYOUT.
kbuild automatically includes it for you in the last few kernels.
> > As in the previous driver, are these barriers strong enough?
> > Or do they need explicit reads of the written addresses to flush the write?
>
> I think they are. Remember, the entire device is integrated in the
> processor. No external buses involved.
Ok.
Dave
--
http://www.codemonkey.org.uk
next prev parent reply other threads:[~2006-08-12 0:07 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-10 21:19 [PATCH] Added MIPS RM9K watchdog driver thomas
2006-08-11 20:07 ` Alan Cox
2006-08-12 16:06 ` Thomas Koeller
2006-08-12 22:41 ` Ralf Baechle
2006-08-12 17:45 ` Thomas Koeller
2006-08-12 20:43 ` Alan Cox
2006-08-11 20:56 ` Dave Jones
2006-08-11 23:49 ` Thomas Koeller
2006-08-11 22:06 ` Oleg Verych
2006-08-12 0:06 ` Dave Jones [this message]
2006-08-12 0:22 ` Ralf Baechle
2006-08-14 14:14 ` Joseph Fannin
2006-08-14 15:30 ` Sam Ravnborg
2006-08-14 16:21 ` Randy.Dunlap
2006-08-14 16:26 ` Dave Jones
2006-08-14 16:27 ` Roland Dreier
2006-08-14 15:50 ` Wim Van Sebroeck
2006-08-14 19:55 ` [PATCH] " Thomas Koeller
2006-08-14 17:25 ` [PATCH] Added " Luca
-- strict thread matches above, loose matches on Subject: below --
2006-11-01 18:46 Wim Van Sebroeck
2006-11-01 18:50 ` Ralf Baechle
2006-11-01 19:11 ` Wim Van Sebroeck
2006-11-01 20:43 ` Sam Ravnborg
2006-11-02 6:11 ` Randy Dunlap
2006-11-02 14:04 ` Ralf Baechle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060812000636.GB28540@redhat.com \
--to=davej@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=thomas@koeller.dyndns.org \
--cc=wim@iguana.be \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox