powerpc: "make install" broken

powerpc: "make install" broken

[Alex Riesen]

[-- Attachment #1: Type: text/plain, Size: 302 bytes --]

I don't know if ever worked before, just tried today on v2.6.17.
Maybe it works, but then it is very different to i386
where it is plain "make install".

I copied the implementation attached from i386 (modified a bit), which
fixed it for me. Maybe the patch will motivate someone to fix it properly...

[-- Attachment #2: ppc-fix-make-install.patch --]
[-- Type: text/x-patch, Size: 1505 bytes --]

From d3d4be5563c68b967841b17cf5557df5d7bfc4dd Mon Sep 17 00:00:00 2001
From: Alex Riesen <raa.lkml@gmail.com>
Date: Sat, 12 Aug 2006 15:38:42 +0200
Subject: [PATCH] fix make install on ppc

---
 arch/powerpc/Makefile      |    3 +++
 arch/powerpc/boot/Makefile |    4 ++--
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
index ed5b26a..d2c530d 100644
--- a/arch/powerpc/Makefile
+++ b/arch/powerpc/Makefile
@@ -156,6 +156,9 @@ boot := arch/$(ARCH)/boot
 $(BOOT_TARGETS): vmlinux
 	$(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) $(patsubst %,$(boot)/%,$@)
 
+install: vmlinux
+	$(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) BOOTIMAGE=$(KBUILD_IMAGE) install
+
 define archhelp
   @echo '* zImage          - Compressed kernel image (arch/$(ARCH)/boot/zImage.*)'
   @echo '  install         - Install kernel using'
diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
index 840ae59..6bfc3ec 100644
--- a/arch/powerpc/boot/Makefile
+++ b/arch/powerpc/boot/Makefile
@@ -209,7 +209,7 @@ extra-y		+= vmlinux.bin vmlinux.gz
 	@echo -n '  Image: $@ '
 	@if [ -f $@ ]; then echo 'is ready' ; else echo 'not made'; fi
 
-install: $(CONFIGURE) $(BOOTIMAGE)
-	sh -x $(srctree)/$(src)/install.sh "$(KERNELRELEASE)" vmlinux System.map "$(INSTALL_PATH)" "$(BOOTIMAGE)"
+install:
+	sh $(srctree)/$(src)/install.sh "$(KERNELRELEASE)" vmlinux System.map "$(INSTALL_PATH)"
 
 clean-files += $(addprefix $(objtree)/, $(obj-boot) vmlinux.strip)
-- 
1.4.1.gbad4

Re: powerpc: "make install" broken

[Alex Riesen]

On 8/12/06, Alex Riesen <raa.lkml@gmail.com> wrote:
> I don't know if ever worked before, just tried today on v2.6.17.

The error is (retried on 2.6.18-rc4):

if [ -r System.map -a -x /sbin/depmod ]; then /sbin/depmod -ae -F
System.map  2.6.18-rc4; fi
make: *** No rule to make target `install'.  Stop.
make: Leaving directory `/home/raa/v2.6.18'

Re: powerpc: "make install" broken

[Sam Ravnborg]

On Sat, Aug 12, 2006 at 04:29:38PM +0200, Alex Riesen wrote:
> I don't know if ever worked before, just tried today on v2.6.17.
> Maybe it works, but then it is very different to i386
> where it is plain "make install".
> 
> I copied the implementation attached from i386 (modified a bit), which
> fixed it for me. Maybe the patch will motivate someone to fix it properly...

> From d3d4be5563c68b967841b17cf5557df5d7bfc4dd Mon Sep 17 00:00:00 2001
> From: Alex Riesen <raa.lkml@gmail.com>
> Date: Sat, 12 Aug 2006 15:38:42 +0200
> Subject: [PATCH] fix make install on ppc
> 
> ---
>  arch/powerpc/Makefile      |    3 +++
>  arch/powerpc/boot/Makefile |    4 ++--
>  2 files changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
> index ed5b26a..d2c530d 100644
> --- a/arch/powerpc/Makefile
> +++ b/arch/powerpc/Makefile
> @@ -156,6 +156,9 @@ boot := arch/$(ARCH)/boot
>  $(BOOT_TARGETS): vmlinux
>  	$(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) $(patsubst %,$(boot)/%,$@)
>  
> +install: vmlinux
> +	$(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) BOOTIMAGE=$(KBUILD_IMAGE) install
NACK - the install target shall not try to build the kernel - the
vmlinux dependency is long gone from i386.

	Sam

Re: powerpc: "make install" broken

[Alex Riesen]

[-- Attachment #1: Type: text/plain, Size: 560 bytes --]

On 8/12/06, Sam Ravnborg <sam@ravnborg.org> wrote:
> > I don't know if ever worked before, just tried today on v2.6.17.
> > Maybe it works, but then it is very different to i386
> > where it is plain "make install".
> >
> > I copied the implementation attached from i386 (modified a bit), which
> > fixed it for me. Maybe the patch will motivate someone to fix it properly...
> NACK - the install target shall not try to build the kernel - the
> vmlinux dependency is long gone from i386.

Agreed, updated, rediffed, attached
(sorry for attach, that's gmail).

[-- Attachment #2: ppc-fix-make-install.patch --]
[-- Type: text/x-patch, Size: 1156 bytes --]

diff --git a/arch/powerpc/Makefile b/arch/powerpc/Makefile
index ed5b26a..85b0c4b 100644
--- a/arch/powerpc/Makefile
+++ b/arch/powerpc/Makefile
@@ -156,6 +156,9 @@ boot := arch/$(ARCH)/boot
 $(BOOT_TARGETS): vmlinux
 	$(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) $(patsubst %,$(boot)/%,$@)
 
+install:
+	$(Q)$(MAKE) ARCH=ppc64 $(build)=$(boot) BOOTIMAGE=$(KBUILD_IMAGE) install
+
 define archhelp
   @echo '* zImage          - Compressed kernel image (arch/$(ARCH)/boot/zImage.*)'
   @echo '  install         - Install kernel using'
diff --git a/arch/powerpc/boot/Makefile b/arch/powerpc/boot/Makefile
index 840ae59..6bfc3ec 100644
--- a/arch/powerpc/boot/Makefile
+++ b/arch/powerpc/boot/Makefile
@@ -209,7 +209,7 @@ extra-y		+= vmlinux.bin vmlinux.gz
 	@echo -n '  Image: $@ '
 	@if [ -f $@ ]; then echo 'is ready' ; else echo 'not made'; fi
 
-install: $(CONFIGURE) $(BOOTIMAGE)
-	sh -x $(srctree)/$(src)/install.sh "$(KERNELRELEASE)" vmlinux System.map "$(INSTALL_PATH)" "$(BOOTIMAGE)"
+install:
+	sh $(srctree)/$(src)/install.sh "$(KERNELRELEASE)" vmlinux System.map "$(INSTALL_PATH)"
 
 clean-files += $(addprefix $(objtree)/, $(obj-boot) vmlinux.strip)

Re: powerpc: "make install" broken

[Olaf Hering]

On Sat, Aug 12, 2006 at 04:59:24PM +0200, Alex Riesen wrote:
> On 8/12/06, Sam Ravnborg <sam@ravnborg.org> wrote:
> >> I don't know if ever worked before, just tried today on v2.6.17.
> >> Maybe it works, but then it is very different to i386
> >> where it is plain "make install".
> >>
> >> I copied the implementation attached from i386 (modified a bit), which
> >> fixed it for me. Maybe the patch will motivate someone to fix it 
> >properly...
> >NACK - the install target shall not try to build the kernel - the
> >vmlinux dependency is long gone from i386.
> 
> Agreed, updated, rediffed, attached

does it do the same as before? $BOOTIMAGE handling may be broken.
At least $5 is not handled anymore, someone else broke it without updating the comment.


> (sorry for attach, that's gmail).

there is no excuse for using gmail...