public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* stack-protect in conflict with CROSS_COMPILE
@ 2006-08-14 12:07 Matthew Wilcox
  2006-08-14 14:14 ` Ralf Baechle
  0 siblings, 1 reply; 2+ messages in thread
From: Matthew Wilcox @ 2006-08-14 12:07 UTC (permalink / raw)
  To: Sam Ravnborg; +Cc: parisc-linux, linux-kernel


Hi Sam,

We've stumbled on a problem with -fno-stack-protector and CROSS_COMPILE:

CFLAGS          := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
                   -fno-strict-aliasing -fno-common
# Force gcc to behave correct even for buggy distributions
CFLAGS          += $(call cc-option, -fno-stack-protector)

round about line 310 of Makefile will cause CC to be called before we
get a chance to set CROSS_COMPILE in arch/parisc/Makefile.  For people
who are compiling 64-bit parisc kernels, this means the wrong gcc gets
called, and sometimes the compiler versions are out of sync.

We will have similar problems with:

CFLAGS          += -fno-omit-frame-pointer $(call cc-option,-fno-optimize-sibling-calls,)

Should we include the arch Makefile earlier in the proceedings?

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: stack-protect in conflict with CROSS_COMPILE
  2006-08-14 12:07 stack-protect in conflict with CROSS_COMPILE Matthew Wilcox
@ 2006-08-14 14:14 ` Ralf Baechle
  0 siblings, 0 replies; 2+ messages in thread
From: Ralf Baechle @ 2006-08-14 14:14 UTC (permalink / raw)
  To: Matthew Wilcox; +Cc: Sam Ravnborg, parisc-linux, linux-kernel

On Mon, Aug 14, 2006 at 06:07:29AM -0600, Matthew Wilcox wrote:

> Hi Sam,
> 
> We've stumbled on a problem with -fno-stack-protector and CROSS_COMPILE:
> 
> CFLAGS          := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
>                    -fno-strict-aliasing -fno-common
> # Force gcc to behave correct even for buggy distributions
> CFLAGS          += $(call cc-option, -fno-stack-protector)
> 
> round about line 310 of Makefile will cause CC to be called before we
> get a chance to set CROSS_COMPILE in arch/parisc/Makefile.  For people
> who are compiling 64-bit parisc kernels, this means the wrong gcc gets
> called, and sometimes the compiler versions are out of sync.
> 
> We will have similar problems with:
> 
> CFLAGS          += -fno-omit-frame-pointer $(call cc-option,-fno-optimize-sibling-calls,)
> 
> Should we include the arch Makefile earlier in the proceedings?

The -fno-stack-protector issue also affects MIPS.

  Ralf

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2006-08-14 14:14 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-14 12:07 stack-protect in conflict with CROSS_COMPILE Matthew Wilcox
2006-08-14 14:14 ` Ralf Baechle

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox