public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Ralf Baechle <ralf@linux-mips.org>
To: Matthew Wilcox <matthew@wil.cx>
Cc: Sam Ravnborg <sam@ravnborg.org>,
	parisc-linux@parisc-linux.org, linux-kernel@vger.kernel.org
Subject: Re: stack-protect in conflict with CROSS_COMPILE
Date: Mon, 14 Aug 2006 15:14:04 +0100	[thread overview]
Message-ID: <20060814141404.GA4074@linux-mips.org> (raw)
In-Reply-To: <20060814120729.GB4340@parisc-linux.org>

On Mon, Aug 14, 2006 at 06:07:29AM -0600, Matthew Wilcox wrote:

> Hi Sam,
> 
> We've stumbled on a problem with -fno-stack-protector and CROSS_COMPILE:
> 
> CFLAGS          := -Wall -Wundef -Wstrict-prototypes -Wno-trigraphs \
>                    -fno-strict-aliasing -fno-common
> # Force gcc to behave correct even for buggy distributions
> CFLAGS          += $(call cc-option, -fno-stack-protector)
> 
> round about line 310 of Makefile will cause CC to be called before we
> get a chance to set CROSS_COMPILE in arch/parisc/Makefile.  For people
> who are compiling 64-bit parisc kernels, this means the wrong gcc gets
> called, and sometimes the compiler versions are out of sync.
> 
> We will have similar problems with:
> 
> CFLAGS          += -fno-omit-frame-pointer $(call cc-option,-fno-optimize-sibling-calls,)
> 
> Should we include the arch Makefile earlier in the proceedings?

The -fno-stack-protector issue also affects MIPS.

  Ralf

      reply	other threads:[~2006-08-14 14:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-14 12:07 stack-protect in conflict with CROSS_COMPILE Matthew Wilcox
2006-08-14 14:14 ` Ralf Baechle [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060814141404.GA4074@linux-mips.org \
    --to=ralf@linux-mips.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=matthew@wil.cx \
    --cc=parisc-linux@parisc-linux.org \
    --cc=sam@ravnborg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox