Re: 2.6.18-rc4-mm1: drivers/video/sis/ compile error

Michal Piotrowski
2006-08-13T16:29:49Z

On 13/08/06, Adrian Bunk <bunk@stusta.de> wrote:
> On Sun, Aug 13, 2006 at 01:24:54AM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.18-rc3-mm2:
> >...
> > +drivers-video-sis-sis_mainh-removal-of-old.patch
> >...
> > fbdev updates
> >...
>
> This patch removes too much:
>
> <-- snip -->
>
> ...
> CC drivers/video/sis/sis_main.o
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm1/drivers/video/sis/sis_main.c:
> In function 'sisfb_setdefaultparms':
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm1/drivers/video/sis/sis_main.c:91:
> error: 'sisfb_mode_idx' undeclared (first use in this function)
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm1/drivers/video/sis/sis_main.c:91:
> error: (Each undeclared identifier is reported only once
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm1/drivers/video/sis/sis_main.c:91:
> error: for each function it appears in.)
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm1/drivers/video/sis/sis_main.c:
> In function 'sisfb_search_vesamode':
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm1/drivers/video/sis/sis_main.c:129:
> error: 'sisfb_mode_idx' undeclared (first use in this function)
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm1/drivers/video/sis/sis_main.c:
> In function 'sisfb_search_mode':
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm1/drivers/video/sis/sis_main.c:172:
> error: 'sisfb_mode_idx' undeclared (first use in this function)
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm1/drivers/video/sis/sis_main.c:
> In function 'sisfb_probe':
> /home/bunk/linux/kernel-2.6/linux-2.6.18-rc4-mm1/drivers/video/sis/sis_main.c:5813:
> error: 'sisfb_mode_idx' undeclared (first use in this function)
> make[4]: *** [drivers/video/sis/sis_main.o] Error 1

I'll take a closer look at this. I have tested this with allyesconfig
on 2006-08-08-00-59 mm snapshot, but now it doesn't build when
CONFIG_FB_SIS=y (CONFIG_FB_SIS=m builds fine for me).

Thanks for pointing that out.

>
> <-- snip -->
>
> cu
> Adrian
>

Regards,
Michal

--
Michal K. K. Piotrowski
LTG - Linux Testers Group
(http://www.stardust.webpages.pl/ltg/wiki/)