* [2.6 patch] drivers/acpi/osl.c: fix a NULL check
@ 2006-08-15 0:41 Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2006-08-15 0:41 UTC (permalink / raw)
To: Bob Moore, Len Brown; +Cc: linux-acpi, linux-kernel
This patch fixes a non-working NULL check introduced by commit
b229cf92eee616c7cb5ad8cdb35a19b119f00bc8.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.18-rc4-mm1/drivers/acpi/osl.c.old 2006-08-15 00:43:30.000000000 +0200
+++ linux-2.6.18-rc4-mm1/drivers/acpi/osl.c 2006-08-15 00:43:55.000000000 +0200
@@ -1030,7 +1030,7 @@
acpi_os_create_cache(char *name, u16 size, u16 depth, acpi_cache_t ** cache)
{
*cache = kmem_cache_create(name, size, 0, 0, NULL, NULL);
- if (cache == NULL)
+ if (*cache == NULL)
return AE_ERROR;
else
return AE_OK;
^ permalink raw reply [flat|nested] 2+ messages in thread* [2.6 patch] drivers/acpi/osl.c: fix a NULL check
@ 2006-11-20 21:06 Adrian Bunk
0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2006-11-20 21:06 UTC (permalink / raw)
To: Andrew Morton; +Cc: Bob Moore, Len Brown, linux-acpi, linux-kernel
This patch fixes a non-working NULL check introduced by commit
b229cf92eee616c7cb5ad8cdb35a19b119f00bc8.
Spotted by the Coverity checker.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 15 Aug 2006
--- linux-2.6.18-rc4-mm1/drivers/acpi/osl.c.old 2006-08-15 00:43:30.000000000 +0200
+++ linux-2.6.18-rc4-mm1/drivers/acpi/osl.c 2006-08-15 00:43:55.000000000 +0200
@@ -1030,7 +1030,7 @@
acpi_os_create_cache(char *name, u16 size, u16 depth, acpi_cache_t ** cache)
{
*cache = kmem_cache_create(name, size, 0, 0, NULL, NULL);
- if (cache == NULL)
+ if (*cache == NULL)
return AE_ERROR;
else
return AE_OK;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-11-20 21:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-08-15 0:41 [2.6 patch] drivers/acpi/osl.c: fix a NULL check Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2006-11-20 21:06 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox