Re: [PATCH] cleanup and remove some extra spinlocks from rtmutex

Oleg Nesterov
2006-08-15T10:22:18Z

On 08/15, Esben Nielsen wrote:
>
> On Tue, 15 Aug 2006, Oleg Nesterov wrote:
> >
> >Sure, this needs a comment.
>
> It is even better if you can read the code without a comment. Good code
> doesn't need comments.

Yes. But from my point of view, the current code needs a comment to explain
why do we take ->pi_lock, this is hard to understand at least to me.

It is even better if we don't take ->pi_lock for ->wait_list manipulation.

Imho.

Oleg.