Re: [PATCH for review] [140/145] i386: mark cpu_dev structures as __cpuinitdata

Magnus Damm
2006-08-14T01:25:15Z

On Fri, 2006-08-11 at 11:24 -0400, Chuck Ebbert wrote:
> In-Reply-To: <20060810193740.9133413C0B@wotan.suse.de>
>
> On Thu, 10 Aug 2006 21:37:40 +0200, Andi Kleen wrote:
>
> > From: Magnus Damm <magnus@valinux.co.jp>
> >
> > The different cpu_dev structures are all used from __cpuinit callers what
> > I can tell. So mark them as __cpuinitdata instead of __initdata. I am a
> > little bit unsure about arch/i386/common.c:default_cpu, especially when it
> > comes to the purpose of this_cpu.
>
> But none of these CPUs supports hotplug and only one (AMD) does SMP.
> So this is just wasting space in the kernel at runtime.

How could this be wasting space? If you compile with CONFIG_HOTPLUG_CPU
disabled then __cpuinitdata will become __initdata - ie the same as
before. Not a single byte wasted what I can tell.

The first version of this patch simply added a missing __init to some
function, but I was then corrected by akpm that __cpuinit should be used
instead.

Thanks,

/ magnus