Re: [PATCH for review] [140/145] i386: mark cpu_dev structures as __cpuinitdata

Chuck Ebbert
2006-08-11T15:29:04Z

In-Reply-To: <20060810193740.9133413C0B@wotan.suse.de>

On Thu, 10 Aug 2006 21:37:40 +0200, Andi Kleen wrote:

> From: Magnus Damm <magnus@valinux.co.jp>
>
> The different cpu_dev structures are all used from __cpuinit callers what
> I can tell. So mark them as __cpuinitdata instead of __initdata. I am a
> little bit unsure about arch/i386/common.c:default_cpu, especially when it
> comes to the purpose of this_cpu.

But none of these CPUs supports hotplug and only one (AMD) does SMP.
So this is just wasting space in the kernel at runtime.

If anything I would only do this for AMD.

Same for the other patch that does more of this kind of change.

(IIRC I tried to do this a while ago and was told not to.)

--
Chuck