CONFIG_NETDEVICES does not do anything

CONFIG_NETDEVICES does not do anything

[Jan Engelhardt]

Hello,


when deselecting CONFIG_NETDEVICES, many selectable items (PHY device 
support, Ethernet 10/100/1000/10000) stay in place. Is there a reason they 
are lacking 'depends on NETDEVICES' or did I found a bug^W glitch?

Jan Engelhardt
-- 

Re: CONFIG_NETDEVICES does not do anything

[Sam Ravnborg]

On Thu, Aug 10, 2006 at 08:34:30AM +0200, Jan Engelhardt wrote:
> Hello,
> 
> 
> when deselecting CONFIG_NETDEVICES, many selectable items (PHY device 
> support, Ethernet 10/100/1000/10000) stay in place. Is there a reason they 
> are lacking 'depends on NETDEVICES' or did I found a bug^W glitch?
It was changed by appended commit.
I do not see why the if/endif was removed - Paolo?

	Sam


commit 6967bd81d883ed325fd58840ee02a8da60458e6b
Author: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
Date:   Fri Feb 3 01:45:21 2006 -0800

    [PATCH] Kbuild menu - hide empty NETDEVICES menu when NET is disabled
    
    Make the whole netdevices menu depend on NET, rather than having an empty
    submenu when networking is disabled.
    
    Indeed, almost the whole body of the menu was surrounded by if NETDEVICES,
    and what was outside depended on NETCONSOLE which is inside the menu.
    
    Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
    Signed-off-by: Andrew Morton <akpm@osdl.org>
    Signed-off-by: Jeff Garzik <jgarzik@pobox.com>

diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
index 6a6a084..47c72a6 100644
--- a/drivers/net/Kconfig
+++ b/drivers/net/Kconfig
@@ -4,9 +4,9 @@ # Network device configuration
 #
 
 menu "Network device support"
+	depends on NET
 
 config NETDEVICES
-	depends on NET
 	default y if UML
 	bool "Network device support"
 	---help---
@@ -24,9 +24,6 @@ config NETDEVICES
 
 	  If unsure, say Y.
 
-# All the following symbols are dependent on NETDEVICES - do not repeat
-# that for each of the symbols.
-if NETDEVICES
 
 config IFB
 	tristate "Intermediate Functional Block support"
@@ -2718,8 +2715,6 @@ config NETCONSOLE
 	If you want to log kernel messages over the network, enable this.
 	See <file:Documentation/networking/netconsole.txt> for details.
 
-endif #NETDEVICES
-
 config NETPOLL
 	def_bool NETCONSOLE
 

Re: CONFIG_NETDEVICES does not do anything

[Blaisorblade]

On Sunday 13 August 2006 21:27, Sam Ravnborg wrote:
> On Thu, Aug 10, 2006 at 08:34:30AM +0200, Jan Engelhardt wrote:
> > Hello,
> >
> >
> > when deselecting CONFIG_NETDEVICES, many selectable items (PHY device
> > support, Ethernet 10/100/1000/10000) stay in place. Is there a reason
> > they are lacking 'depends on NETDEVICES' or did I found a bug^W glitch?
>
> It was changed by appended commit.
> I do not see why the if/endif was removed - Paolo?

I did not consider the "enable NET disable NETDEVICES" case, I was too much in 
a hurry. Sorry for that.

> diff --git a/drivers/net/Kconfig b/drivers/net/Kconfig
> index 6a6a084..47c72a6 100644
> --- a/drivers/net/Kconfig
> +++ b/drivers/net/Kconfig
> @@ -4,9 +4,9 @@ # Network device configuration
>  #
>
>  menu "Network device support"
> +	depends on NET
>
>  config NETDEVICES
> -	depends on NET
>  	default y if UML
>  	bool "Network device support"
>  	---help---

This hunk can be left, it's just the below ones which needs to be reversed.

> @@ -24,9 +24,6 @@ config NETDEVICES
>
>  	  If unsure, say Y.
>
> -# All the following symbols are dependent on NETDEVICES - do not repeat
> -# that for each of the symbols.
> -if NETDEVICES
>
>  config IFB
>  	tristate "Intermediate Functional Block support"
> @@ -2718,8 +2715,6 @@ config NETCONSOLE
>  	If you want to log kernel messages over the network, enable this.
>  	See <file:Documentation/networking/netconsole.txt> for details.
>
> -endif #NETDEVICES
> -
>  config NETPOLL
>  	def_bool NETCONSOLE

-- 
Inform me of my mistakes, so I can keep imitating Homer Simpson's "Doh!".
Paolo Giarrusso, aka Blaisorblade
http://www.user-mode-linux.org/~blaisorblade
Chiacchiera con i tuoi amici in tempo reale! 
 http://it.yahoo.com/mail_it/foot/*http://it.messenger.yahoo.com