Re: [patch] sched: group CPU power setup cleanup

[Andrew Morton <akpm@osdl.org>]

On Tue, 15 Aug 2006 21:24:55 -0700
Paul Jackson <pj@sgi.com> wrote:

> Thanks for the cleanup patch resend, Suresh.
> 
> > Resending the new patch. Before patch had some issues for Andy and hence
> > dropped.
> > 
> > Andrew, Please add this to -mm. This patch is against 2.6.18-rc4.
> > There might be a small conflict while applying to -mm. Let me know if you
> > want a patch on top of -mm.
> > 
> > thanks,
> > suresh
> > 
> > --
> 
> I found the above patch commentary frustrating to read, as it told me
> very little, and teased me with reference to details that are left
> unsaid.
> 
> Can we work on this patch's opening text a bit more?

Believe it or not, I usually suffer in silence.

> 
> ..
>
> > + * cpu_power indicates the computing power of each sched group. This is
> > + * used for distributing the load between different sched groups
> > + * in a sched domain.
> 
> Thanks for explaining what cpu_power means.
>

Hope not.  To me, "computing power" means megaflops/sec, or Dhrystones
(don't ask) or whatever.  If that's what "cpu_power" is referring to then
the name is hopelessly ambiguous with peak joules/sec and a big renaming is
due.